Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/history/history_unittest.cc

Issue 6969009: Reduced the lifetime of DownloadCreateInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Stupid clang! Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_unittest.cc
diff --git a/chrome/browser/history/history_unittest.cc b/chrome/browser/history/history_unittest.cc
index 67a586974441c1139b83d10d0b6ba6978b4526e3..6bdc407d2b8b2838b329e7e87c714b1030caf116 100644
--- a/chrome/browser/history/history_unittest.cc
+++ b/chrome/browser/history/history_unittest.cc
@@ -37,7 +37,7 @@
#include "base/task.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/download/download_item.h"
-#include "chrome/browser/history/download_create_info.h"
+#include "chrome/browser/history/download_history_info.h"
#include "chrome/browser/history/history.h"
#include "chrome/browser/history/history_backend.h"
#include "chrome/browser/history/history_database.h"
@@ -184,8 +184,14 @@ class HistoryTest : public testing::Test {
}
int64 AddDownload(int32 state, const Time& time) {
- DownloadCreateInfo download(FilePath(FILE_PATH_LITERAL("foo-path")),
- GURL("foo-url"), time, 0, 512, state, 0, false);
+ DownloadHistoryInfo download(FilePath(FILE_PATH_LITERAL("foo-path")),
+ GURL("foo-url"),
+ GURL(""),
+ time,
+ 0,
+ 512,
+ state,
+ 0);
return db_->CreateDownload(download);
}
@@ -304,7 +310,7 @@ TEST_F(HistoryTest, ClearBrowsingData_Downloads) {
Time month_ago = now - TimeDelta::FromDays(30);
// Initially there should be nothing in the downloads database.
- std::vector<DownloadCreateInfo> downloads;
+ std::vector<DownloadHistoryInfo> downloads;
db_->QueryDownloads(&downloads);
EXPECT_EQ(0U, downloads.size());
« no previous file with comments | « chrome/browser/history/history_marshaling.h ('k') | chrome/browser/renderer_host/download_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698