Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/browser/history/history.h

Issue 6969009: Reduced the lifetime of DownloadCreateInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Stupid clang! Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/download_history_info.cc ('k') | chrome/browser/history/history.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history.h
diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h
index 5fcf1ea439e7a357cc9cc3b6b6f9061d242d88f4..b976c6a7d36ec7b2b2f55b6a9f8ab80aca682582 100644
--- a/chrome/browser/history/history.h
+++ b/chrome/browser/history/history.h
@@ -27,7 +27,7 @@
#include "content/common/page_transition_types.h"
class BookmarkService;
-struct DownloadCreateInfo;
+struct DownloadHistoryInfo;
class FilePath;
class GURL;
class HistoryURLProvider;
@@ -416,24 +416,25 @@ class HistoryService : public CancelableRequestProvider,
// Implemented by the caller of 'CreateDownload' below, and is called when the
// history service has created a new entry for a download in the history db.
- typedef Callback2<DownloadCreateInfo, int64>::Type
+ typedef Callback2<int32, int64>::Type
DownloadCreateCallback;
// Begins a history request to create a new persistent entry for a download.
// 'info' contains all the download's creation state, and 'callback' runs
// when the history service request is complete.
- Handle CreateDownload(const DownloadCreateInfo& info,
+ Handle CreateDownload(int32 id,
+ const DownloadHistoryInfo& info,
CancelableRequestConsumerBase* consumer,
DownloadCreateCallback* callback);
// Implemented by the caller of 'QueryDownloads' below, and is called when the
// history service has retrieved a list of all download state. The call
- typedef Callback1<std::vector<DownloadCreateInfo>*>::Type
+ typedef Callback1<std::vector<DownloadHistoryInfo>*>::Type
DownloadQueryCallback;
// Begins a history request to retrieve the state of all downloads in the
// history db. 'callback' runs when the history service request is complete,
- // at which point 'info' contains an array of DownloadCreateInfo, one per
+ // at which point 'info' contains an array of DownloadHistoryInfo, one per
// download.
Handle QueryDownloads(CancelableRequestConsumerBase* consumer,
DownloadQueryCallback* callback);
« no previous file with comments | « chrome/browser/history/download_history_info.cc ('k') | chrome/browser/history/history.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698