Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5767)

Unified Diff: chrome/browser/download/download_safe_browsing_client.h

Issue 6969009: Reduced the lifetime of DownloadCreateInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Stupid clang! Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_safe_browsing_client.h
diff --git a/chrome/browser/download/download_safe_browsing_client.h b/chrome/browser/download/download_safe_browsing_client.h
index 762373392bb33cd9597fbe65ae329e42319c750d..98fb220cbd3f78af52d85f78bed8edb24cbae21c 100644
--- a/chrome/browser/download/download_safe_browsing_client.h
+++ b/chrome/browser/download/download_safe_browsing_client.h
@@ -11,8 +11,6 @@
#include "base/time.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
-struct DownloadCreateInfo;
-
// This is a helper class used by DownloadManager to check a download URL with
// SafeBrowsingService. The client is refcounted and will be released once
// there is no reference to it.
@@ -32,7 +30,7 @@ class DownloadSBClient
: public SafeBrowsingService::Client,
public base::RefCountedThreadSafe<DownloadSBClient> {
public:
- typedef Callback2<DownloadCreateInfo*, bool>::Type UrlDoneCallback;
+ typedef Callback2<int32, bool>::Type UrlDoneCallback;
typedef Callback2<int32, bool>::Type HashDoneCallback;
DownloadSBClient(int32 download_id,
@@ -43,7 +41,7 @@ class DownloadSBClient
// For each DownloadSBClient instance, either CheckDownloadUrl or
// CheckDownloadHash can be called, and be called only once.
// DownloadSBClient instance.
- void CheckDownloadUrl(DownloadCreateInfo* info, UrlDoneCallback* callback);
+ void CheckDownloadUrl(UrlDoneCallback* callback);
void CheckDownloadHash(const std::string& hash, HashDoneCallback* callback);
private:
@@ -91,9 +89,6 @@ class DownloadSBClient
scoped_ptr<UrlDoneCallback> url_done_callback_;
scoped_ptr<HashDoneCallback> hash_done_callback_;
- // Not owned by this class.
- DownloadCreateInfo* info_;
-
int32 download_id_;
scoped_refptr<SafeBrowsingService> sb_service_;
« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | chrome/browser/download/download_safe_browsing_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698