chrome/browser/automation/automation_provider.cc - Issue 6969009: Reduced the lifetime of DownloadCreateInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider.cc

Issue 6969009: Reduced the lifetime of DownloadCreateInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed spurious DCHECK. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/automation_provider.cc

diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc

index c032eb551c95db641dc6328da4d0d03a189ec693..1bfd100058c7e9570491f32039984c125b9f7e5b 100644

--- a/chrome/browser/automation/automation_provider.cc

+++ b/chrome/browser/automation/automation_provider.cc

@@ -252,7 +252,7 @@ DictionaryValue* AutomationProvider::GetDictionaryFromDownloadItem(

DictionaryValue* dl_item_value = new DictionaryValue;

dl_item_value->SetInteger("id", static_cast<int>(download->id()));

- dl_item_value->SetString("url", download->url().spec());

+ dl_item_value->SetString("url", download->GetUrl().spec());

dl_item_value->SetString("referrer_url", download->referrer_url().spec());

dl_item_value->SetString("file_name",

download->GetFileNameToReportUser().value());