Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chrome/browser/download/download_util.h

Issue 6969009: Reduced the lifetime of DownloadCreateInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed structure accessors from DownloadItem, per request. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_util.h
diff --git a/chrome/browser/download/download_util.h b/chrome/browser/download/download_util.h
index 376fc183365719de6307bec353704283ce337f5c..520d0e6074fa54ef6a301e5e1999046e808df411 100644
--- a/chrome/browser/download/download_util.h
+++ b/chrome/browser/download/download_util.h
@@ -61,8 +61,11 @@ void GenerateExtension(const FilePath& file_name,
FilePath::StringType* generated_extension);
// Create a file name based on the response from the server.
-void GenerateFileNameFromInfo(DownloadCreateInfo* info,
- FilePath* generated_name);
+void GenerateFileNameFromRequest(const GURL& url,
+ const std::string& content_disposition,
+ const std::string& referrer_charset,
+ const std::string& mime_type,
+ FilePath* generated_name);
// Create a file name based on the response from the server.
void GenerateFileName(const GURL& url,
@@ -267,9 +270,15 @@ FilePath GetCrDownloadPath(const FilePath& suggested_path);
// Returns true if this download should show the "dangerous file" warning.
// Various factors are considered, such as the type of the file, whether a
-// user action initiated the download, and whether the user has explictly
+// user action initiated the download, and whether the user has explicitly
// marked the file type as "auto open".
-bool IsDangerous(DownloadCreateInfo* info, Profile* profile, bool auto_open);
+bool IsDangerous(const GURL& url,
+ const GURL& referrer_url,
+ const FilePath& suggested_path,
+ bool has_user_gesture,
+ bool is_extension_install,
+ Profile* profile,
+ bool auto_open);
} // namespace download_util

Powered by Google App Engine
This is Rietveld 408576698