Issue 6968007: NaCl: Conditionalise copying of IRT library based on "disable_nacl" flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6968007: NaCl: Conditionalise copying of IRT library based on "disable_nacl" flag (Closed)

Created:
9 years, 7 months ago by Mark Seaborn

Modified:
9 years, 5 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, bradn, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

NaCl: Conditionalise copying of IRT library based on "disable_nacl" flag This makes it possible to build Chromium when download_nacl_irt.py has not been run. BUG=http://bugs.gentoo.org/show_bug.cgi?id=366413 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84627

Patch Set 1 #

Patch Set 2 : Move to end of block #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	chrome/chrome_exe.gypi	View	1	2 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks!

Expand Messages | Collapse Messages