Issue 6967006: Disk cache: Make sure the list of unused entries is not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6967006: Disk cache: Make sure the list of unused entries is not (Closed)

Created:
9 years, 7 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: Make sure the list of unused entries is not depleted if we are not reaching the time targets for any of the lists. BUG=79491 TEST=netunittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84877

Patch Set 1 #

Patch Set 2 : Fix stupid gcc warning #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -22 lines)			Patch
M	net/disk_cache/backend_unittest.cc	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_base.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/disk_cache/eviction.h	View		2 chunks	+2 lines, -2 lines	2 comments	Download
M	net/disk_cache/eviction.cc	View	1	5 chunks	+19 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gavinp

With the spelling fixed, lgtm. http://codereview.chromium.org/6967006/diff/4001/net/disk_cache/eviction.h File net/disk_cache/eviction.h (right): http://codereview.chromium.org/6967006/diff/4001/net/disk_cache/eviction.h#newcode69 net/disk_cache/eviction.h:69: int SelectListByLenght(Rankings::ScopedRankingsBlock* next); While ...

9 years, 7 months ago (2011-05-10 21:23:23 UTC) #2

rvargas (doing something else)

9 years, 7 months ago (2011-05-10 21:32:37 UTC) #3

Thanks.

http://codereview.chromium.org/6967006/diff/4001/net/disk_cache/eviction.h
File net/disk_cache/eviction.h (right):

http://codereview.chromium.org/6967006/diff/4001/net/disk_cache/eviction.h#ne...
net/disk_cache/eviction.h:69: int
SelectListByLenght(Rankings::ScopedRankingsBlock* next);
On 2011/05/10 21:23:23, gavinp wrote:
> While we're at it, SelectListByLength is a good fix.

Done.

Expand Messages | Collapse Messages