Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 6966043: Proxy PPB_Instance_Private and PPP_Instance_Private. (Closed)

Created:
9 years, 7 months ago by dmichael (off chromium)
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Proxy PPB_Instance_Private and PPP_Instance_Private. BUG=82356 TEST=Run example plugin out-of-process, click on it. Before this, it crashes the plugin. After, behaves as expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86640

Patch Set 1 : fix missing include #

Patch Set 2 : Fix ID mismatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -0 lines) Patch
M ppapi/ppapi_proxy.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_id.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +18 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_instance_private_proxy.h View 1 chunk +53 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_instance_private_proxy.cc View 1 1 chunk +143 lines, -0 lines 0 comments Download
A ppapi/proxy/ppp_instance_private_proxy.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ppapi/proxy/ppp_instance_private_proxy.cc View 1 1 chunk +78 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmichael (off chromium)
9 years, 7 months ago (2011-05-25 00:04:31 UTC) #1
brettw
9 years, 7 months ago (2011-05-25 05:19:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698