src/ia32/ic-ia32.cc - Issue 6966041: Add complete ElementKind information directly to Map for objects with elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/ic-ia32.cc

Issue 6966041: Add complete ElementKind information directly to Map for objects with elements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: implement all platforms Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/ic-ia32.cc

diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc

index a2d9ca80fe973490854251e79c84ec8cdb99be56..53916b4c589cb3e78cf693a289e07bcd1a6abfba 100644

--- a/src/ia32/ic-ia32.cc

+++ b/src/ia32/ic-ia32.cc

@@ -484,11 +484,8 @@ void KeyedLoadIC::GenerateGeneric(MacroAssembler* masm) {

GenerateKeyedLoadReceiverCheck(

masm, edx, ecx, Map::kHasIndexedInterceptor, &slow);

- // Check the "has fast elements" bit in the receiver's map which is

- // now in ecx.

- __ test_b(FieldOperand(ecx, Map::kBitField2Offset),

- 1 << Map::kHasFastElements);

- __ j(zero, &check_number_dictionary);

+ // Check if receiver's map to see if it has fast elements.

Mads Ager (chromium) 2011/05/30 11:14:24 if receiver's -> the receiver's

danno 2011/06/01 22:29:54 Done.

+ __ CheckFastElements(ecx, &check_number_dictionary);

GenerateFastArrayLoad(masm,

edx,

« src/arm/macro-assembler-arm.cc ('K') | « src/ia32/full-codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | src/ia32/macro-assembler-ia32.cc » ('J')