src/x64/ic-x64.cc - Issue 6966041: Add complete ElementKind information directly to Map for objects with elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/ic-x64.cc

Issue 6966041: Add complete ElementKind information directly to Map for objects with elements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: review feedback Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/ic-x64.cc

diff --git a/src/x64/ic-x64.cc b/src/x64/ic-x64.cc

index 032a3f7e75bd2c92aa906014aa5556fe11a2862f..91f44f6f337207fe57d881c12e97bb9ae0b204b5 100644

--- a/src/x64/ic-x64.cc

+++ b/src/x64/ic-x64.cc

@@ -508,11 +508,8 @@ void KeyedLoadIC::GenerateGeneric(MacroAssembler* masm) {

GenerateKeyedLoadReceiverCheck(

masm, rdx, rcx, Map::kHasIndexedInterceptor, &slow);

- // Check the "has fast elements" bit in the receiver's map which is

- // now in rcx.

- __ testb(FieldOperand(rcx, Map::kBitField2Offset),

- Immediate(1 << Map::kHasFastElements));

- __ j(zero, &check_number_dictionary);

+ // Check the receiver's map to see if it has fast elements.

+ __ CheckFastElements(rcx, &check_number_dictionary);

GenerateFastArrayLoad(masm,

rdx,

« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »