Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4446)

Unified Diff: chrome/browser/renderer_host/chrome_render_message_filter.cc

Issue 6966036: Wrapping blocked filesystems into TabSpecificContentSettings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missed a string. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_render_message_filter.cc
diff --git a/chrome/browser/renderer_host/chrome_render_message_filter.cc b/chrome/browser/renderer_host/chrome_render_message_filter.cc
index 63f19b568ee9bdea720dd211c9516a6e2fd9082c..c18cf59700e8731b929007660394074d469d978e 100644
--- a/chrome/browser/renderer_host/chrome_render_message_filter.cc
+++ b/chrome/browser/renderer_host/chrome_render_message_filter.cc
@@ -365,15 +365,18 @@ void ChromeRenderMessageFilter::OnAllowDOMStorage(int render_view_id,
void ChromeRenderMessageFilter::OnAllowFileSystem(int render_view_id,
const GURL& url,
bool* allowed) {
-
- // TODO(kinuko): Need to notify the UI thread to indicate that
- // there's a blocked content. See the above for inspiration.
ContentSetting setting = host_content_settings_map_->GetContentSetting(
url, CONTENT_SETTINGS_TYPE_COOKIES, "");
DCHECK((setting == CONTENT_SETTING_ALLOW) ||
(setting == CONTENT_SETTING_BLOCK) ||
(setting == CONTENT_SETTING_SESSION_ONLY));
*allowed = setting != CONTENT_SETTING_BLOCK;
+ // If content was blocked, tell the UI to display the blocked content icon.
jochen (gone - plz use gerrit) 2011/05/25 15:54:09 that's not what the following lines do. it's more
Mike West 2011/05/25 16:55:16 Done.
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ NewRunnableFunction(
+ &TabSpecificContentSettings::FileSystemAccessed,
+ render_process_id_, render_view_id, url, !*allowed));
}
void ChromeRenderMessageFilter::OnAllowIndexedDB(int render_view_id,

Powered by Google App Engine
This is Rietveld 408576698