Remove some dead code from full-codegen on all platforms.

src/arm/full-codegen-arm.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 722 matching lines @@
         } else {
           __ mov(r0, Operand(Smi::FromInt(0)));  // No initial value!
           __ Push(cp, r2, r1, r0);
         }
         __ CallRuntime(Runtime::kDeclareContextSlot, 4);
         break;
       }
     }
 
   } else if (prop != NULL) {
-    if (function != NULL || mode == Variable::CONST) {
-      // We are declaring a function or constant that rewrites to a
-      // property.  Use (keyed) IC to set the initial value.  We
-      // cannot visit the rewrite because it's shared and we risk
-      // recording duplicate AST IDs for bailouts from optimized code.
-      ASSERT(prop->obj()->AsVariableProxy() != NULL);
-      { AccumulatorValueContext for_object(this);
-        EmitVariableLoad(prop->obj()->AsVariableProxy()->var());
-      }
-      if (function != NULL) {
-        __ push(r0);
-        VisitForAccumulatorValue(function);
-        __ pop(r2);
-      } else {
-        __ mov(r2, r0);
-        __ LoadRoot(r0, Heap::kTheHoleValueRootIndex);
-      }
-      ASSERT(prop->key()->AsLiteral() != NULL &&
-             prop->key()->AsLiteral()->handle()->IsSmi());
-      __ mov(r1, Operand(prop->key()->AsLiteral()->handle()));
+    ASSERT(mode != Variable::CONST);

[Kevin Millikin (Chromium), 2011/05/24 12:57:27]

This needs a comment that a const declaration of a parameter would be a
redeclaration, and we'd never get here.

[William Hesse, 2011/05/24 14:21:43]

Done.

+    ASSERT(function != NULL);

[Kevin Millikin (Chromium), 2011/05/24 12:57:27]

I think this is wrong:

function f(x) { var x = arguments[0]; }

Has a declaration of x, rewritten to a property, and not a function.  I think
you'll need to keep

if (function != NULL) {
  ...
}

And just emit no code in the function == NULL cases.

[William Hesse, 2011/05/24 14:21:43]

Done.

+    // We are declaring a function that rewrites to a property.
+    // Use (keyed) IC to set the initial value.  We cannot visit the
+    // rewrite because it's shared and we risk recording duplicate AST
+    // IDs for bailouts from optimized code.
+    ASSERT(prop->obj()->AsVariableProxy() != NULL);
+    { AccumulatorValueContext for_object(this);
+      EmitVariableLoad(prop->obj()->AsVariableProxy()->var());
+    }
 
-      Handle<Code> ic = is_strict_mode()
-          ? isolate()->builtins()->KeyedStoreIC_Initialize_Strict()
-          : isolate()->builtins()->KeyedStoreIC_Initialize();
-      EmitCallIC(ic, RelocInfo::CODE_TARGET, AstNode::kNoNumber);
-      // Value in r0 is ignored (declarations are statements).
-    }
+    __ push(r0);
+    VisitForAccumulatorValue(function);
+    __ pop(r2);
+
+    ASSERT(prop->key()->AsLiteral() != NULL &&
+           prop->key()->AsLiteral()->handle()->IsSmi());
+    __ mov(r1, Operand(prop->key()->AsLiteral()->handle()));
+
+    Handle<Code> ic = is_strict_mode()
+        ? isolate()->builtins()->KeyedStoreIC_Initialize_Strict()
+        : isolate()->builtins()->KeyedStoreIC_Initialize();
+    EmitCallIC(ic, RelocInfo::CODE_TARGET, AstNode::kNoNumber);
+    // Value in r0 is ignored (declarations are statements).
   }
 }
 
 
 void FullCodeGenerator::VisitDeclaration(Declaration* decl) {
   EmitDeclaration(decl->proxy()->var(), decl->mode(), decl->fun());
 }
 
 
 void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) {
@@ skipping 3574 matching lines @@
   __ mov(r1, Operand(r1, ASR, 1));  // Un-smi-tag value.
   __ add(pc, r1, Operand(masm_->CodeObject()));
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM