[ChromeOS] Move ChromeOS upgrade check logic into UpgradeDetector.

[ChromeOS] Move ChromeOS upgrade check logic into UpgradeDetector.

- UpgradeDetector::CheckForUpgrade uses ChromeOS update libary
  status for ChromeOS upgrade check;
- Remove ChromeOS specific code from ToolbarView since it could solely
  use UpgradeDetector now;
- Remove notification from update library since UpgradeDetector will do
  this;
- Update WrenchMenuModel to solely talk to UpgradeDetector;

BUG=chromium-os:15272
TEST=Verify fix for chromium-os:15272 and run regression tests for ChromeOS
update.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86491

[Finnur, 2011-05-24 10:38:39]

Very nice. Like the simplification here for the toolbar view.

LGTM, with one question.

http://codereview.chromium.org/6966025/diff/1/chrome/browser/upgrade_detector.cc
File chrome/browser/upgrade_detector.cc (right):

http://codereview.chromium.org/6966025/diff/1/chrome/browser/upgrade_detector...
chrome/browser/upgrade_detector.cc:216:
chromeos::UPDATE_STATUS_UPDATED_NEED_REBOOT) {
I take it this is appropriate to be called on the UI thread?

[Finnur, 2011-05-24 10:40:01]

Ah, ignore my question. This is fine.

LGTM.

On 2011/05/24 10:38:39, Finnur wrote:
> Very nice. Like the simplification here for the toolbar view.
> 
> LGTM, with one question.
> 
>
http://codereview.chromium.org/6966025/diff/1/chrome/browser/upgrade_detector.cc
> File chrome/browser/upgrade_detector.cc (right):
> 
>
http://codereview.chromium.org/6966025/diff/1/chrome/browser/upgrade_detector...
> chrome/browser/upgrade_detector.cc:216:
> chromeos::UPDATE_STATUS_UPDATED_NEED_REBOOT) {
> I take it this is appropriate to be called on the UI thread?

[stevenjb, 2011-05-24 20:30:59]

LGTM