Issue 6966022: ntp4: Make theme attribution separate from chrome logo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6966022: ntp4: Make theme attribution separate from chrome logo. (Closed)

Created:
9 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
csilv

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: Make theme attribution separate from chrome logo. now the chrome logo should always show, but the attribution only shows if the theme has one. I also moved the attribution to the right side because it looks more balanced over there (this didn't break horribly for any of the handful of themes I tested on). Leaving it on the left side, right next to the chrome logo, looks cluttered. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86363

Patch Set 1 #

Patch Set 2 : rtl #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -8 lines)			Patch
M	chrome/browser/resources/ntp4/new_tab.css	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View		1 chunk	+19 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

since arv is gone, you are going to be getting a lot more ntp reviews!

9 years, 7 months ago (2011-05-23 22:24:19 UTC) #1

LGTM

Expand Messages | Collapse Messages