Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5194)

Unified Diff: chrome/common/net/url_fetcher.h

Issue 6966021: Revert 86340 - Move response_container_ into the URLFetcher::Core. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/test_url_fetcher_factory.cc ('k') | chrome/common/net/url_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/net/url_fetcher.h
===================================================================
--- chrome/common/net/url_fetcher.h (revision 86344)
+++ chrome/common/net/url_fetcher.h (working copy)
@@ -263,12 +263,6 @@
static void CancelAll();
protected:
- // How should the response be stored?
- enum ResponseDestinationType {
- STRING, // Default: In a std::string
- TEMP_FILE // Write to a temp file
- };
-
// Returns the delegate.
Delegate* delegate() const;
@@ -281,13 +275,16 @@
// of crbug.com/83592 .
const std::string& GetResponseStringRef() const;
- void SetResponseDestinationForTesting(ResponseDestinationType);
- ResponseDestinationType GetResponseDestinationForTesting() const;
-
private:
friend class URLFetcherTest;
friend class TestURLFetcher;
+ // How should the response be stored?
+ enum ResponseDestinationType {
+ STRING, // Default: In a std::string
+ TEMP_FILE // Write to a temp file
+ };
+
// Only used by URLFetcherTest, returns the number of URLFetcher::Core objects
// actively running.
static int GetNumFetcherCores();
@@ -307,6 +304,9 @@
// Maximum retries allowed.
int max_retries_;
+ // Where should responses be saved?
+ ResponseDestinationType response_destination_;
+
static bool g_interception_enabled;
DISALLOW_COPY_AND_ASSIGN(URLFetcher);
« no previous file with comments | « chrome/common/net/test_url_fetcher_factory.cc ('k') | chrome/common/net/url_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698