Chromium Code Reviews| Index: chrome/browser/prerender/prerender_tracker.h |
| diff --git a/chrome/browser/prerender/prerender_tracker.h b/chrome/browser/prerender/prerender_tracker.h |
| index acd8e8d85e99ccfabe6998883df0ca49d9b55457..b41af81f6e54d086d63f55bd23da83a354e95b82 100644 |
| --- a/chrome/browser/prerender/prerender_tracker.h |
| +++ b/chrome/browser/prerender/prerender_tracker.h |
| @@ -9,7 +9,7 @@ |
| #include <map> |
| #include <set> |
| -#include "base/memory/singleton.h" |
| +#include "base/memory/weak_ptr.h" |
|
mmenke
2011/05/25 00:56:24
nit: No longer needed, now that RenderViewInfo is
dominich
2011/05/25 16:42:28
Done.
|
| #include "base/synchronization/lock.h" |
| #include "chrome/browser/prerender/prerender_final_status.h" |
| @@ -23,8 +23,8 @@ struct RenderViewInfo; |
| // and can be modified on any thread. |
| class PrerenderTracker { |
| public: |
| - // Returns the PrerenderTracker singleton. |
| - static PrerenderTracker* GetInstance(); |
| + PrerenderTracker(); |
| + ~PrerenderTracker(); |
| // Attempts to set the status of the specified RenderViewHost to |
| // FINAL_STATUS_USED. Returns true on success. Returns false if it has |
| @@ -53,28 +53,35 @@ class PrerenderTracker { |
| bool TryCancelOnIOThread(int child_id, int route_id, |
| FinalStatus final_status); |
| - // Returns whether or not a RenderView is prerendering. Can only be called on |
| - // the IO thread. Does not acquire a lock, so may claim a RenderView that has |
| - // been displayed or destroyed is still prerendering. |
| - // TODO(mmenke): Remove external use of this method and make it private. |
| - bool IsPrerenderingOnIOThread(int child_id, int route_id) const; |
| - |
| // Gets the FinalStatus of the specified prerendered RenderView. Returns |
| // |true| and sets |final_status| to the status of the RenderView if it |
| // is found, returns false otherwise. |
| bool GetFinalStatus(int child_id, int route_id, |
| FinalStatus* final_status) const; |
| + // Returns whether or not a RenderView is prerendering. Can only be called on |
| + // the IO thread. Does not acquire a lock, so may claim a RenderView that has |
| + // been displayed or destroyed is still prerendering. |
| + bool IsPrerenderingOnIOThread(int child_id, int route_id) const; |
| + |
| private: |
| - friend struct DefaultSingletonTraits<PrerenderTracker>; |
| friend class PrerenderContents; |
| + FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerNull); |
| FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerUsed); |
| FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerCancelled); |
| FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerCancelledOnIO); |
| FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerCancelledFast); |
| FRIEND_TEST_ALL_PREFIXES(PrerenderTrackerTest, PrerenderTrackerMultiple); |
| +// struct RenderViewInfo { |
|
mmenke
2011/05/25 00:56:24
nit: Remove this. Assume you would have anyways,
dominich
2011/05/25 16:42:28
Done.
|
| +// explicit RenderViewInfo(PrerenderManager* prerender_manager); |
| +// ~RenderViewInfo(); |
| +// |
| +// FinalStatus final_status; |
| +// base::WeakPtr<PrerenderManager> prerender_manager; |
| +// }; |
| + |
| typedef std::pair<int, int> ChildRouteIdPair; |
| // Map of child/route id pairs to final statuses. |
| @@ -82,9 +89,6 @@ class PrerenderTracker { |
| // Set of child/route id pairs that may be prerendering. |
| typedef std::set<ChildRouteIdPair> PossiblyPrerenderingChildRouteIdPairs; |
| - PrerenderTracker(); |
| - ~PrerenderTracker(); |
| - |
| // Must be called when a RenderView starts prerendering, before the first |
| // navigation starts to avoid any races. |
| void OnPrerenderingStarted(int child_id, int route_id, |