Handle <link rel=prerender> in chrome.

Handle <link rel=prerender> in chrome.

This new link rel type is being used for the prerendering experiment
instead of prefetch; this CL depends on webkit patch
https://bugs.webkit.org/show_bug.cgi?id=61297 landing, but, together
with that patch, chrome properly interprets and responds to link
rel=prerender to launch prerendering.

BUG=none
TEST=PrerenderBrowserTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86465

[gavinp, 2011-05-23 20:45:25]

This version works if you patch the referenced webkit review into your webkit
repo, otherwise it doesn't.  I wanted to start reviewing now though, so we could
land it soon after that lands and is gardened in.

[cbentzel, 2011-05-23 20:52:25]

Yes, this looks like it will work.

http://codereview.chromium.org/6966016/diff/1/chrome/test/data/prerender/prer...
File chrome/test/data/prerender/prerender_loader.html (right):

http://codereview.chromium.org/6966016/diff/1/chrome/test/data/prerender/prer...
chrome/test/data/prerender/prerender_loader.html:22: document.write('<link
rel="prerender" href="REPLACE_WITH_PREFETCH_URL"/>');
nit: REPLACE_WITH_PRERENDER_URL

http://codereview.chromium.org/6966016/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/6966016/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/resource_dispatcher_host.cc:2029: // Prefetches &
prerenders are at a lower priority than even
Doesn't matter for PRERENDER case, but I guess you need it due to the
NOTREACHED() in default case.

[mmenke, 2011-05-23 20:57:38]

http://codereview.chromium.org/6966017/, which removes the prerendering code in
ResourceDispatcherHost, will have some implications for this CL.

On 2011/05/23 20:52:25, cbentzel wrote:
> Yes, this looks like it will work.
> 
>
http://codereview.chromium.org/6966016/diff/1/chrome/test/data/prerender/prer...
> File chrome/test/data/prerender/prerender_loader.html (right):
> 
>
http://codereview.chromium.org/6966016/diff/1/chrome/test/data/prerender/prer...
> chrome/test/data/prerender/prerender_loader.html:22: document.write('<link
> rel="prerender" href="REPLACE_WITH_PREFETCH_URL"/>');
> nit: REPLACE_WITH_PRERENDER_URL
> 
>
http://codereview.chromium.org/6966016/diff/1/content/browser/renderer_host/r...
> File content/browser/renderer_host/resource_dispatcher_host.cc (right):
> 
>
http://codereview.chromium.org/6966016/diff/1/content/browser/renderer_host/r...
> content/browser/renderer_host/resource_dispatcher_host.cc:2029: // Prefetches
&
> prerenders are at a lower priority than even
> Doesn't matter for PRERENDER case, but I guess you need it due to the
> NOTREACHED() in default case.

[dominich, 2011-05-23 21:00:03]

http://codereview.chromium.org/6966016/diff/1/chrome/test/functional/prefetch.py
File chrome/test/functional/prefetch.py (right):

http://codereview.chromium.org/6966016/diff/1/chrome/test/functional/prefetch...
chrome/test/functional/prefetch.py:73: <link rel="prerender"
href="static-prefetch-target.html">
Should this should remain as prefetch and should we add another functional test
for prerender?

[tburkard, 2011-05-23 21:48:18]

LGTM

On Mon, May 23, 2011 at 2:00 PM, <dominich@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/6966016/diff/1/chrome/test/functional/prefetch.py
> File chrome/test/functional/prefetch.py (right):
>
>
>
http://codereview.chromium.org/6966016/diff/1/chrome/test/functional/prefetch...
> chrome/test/functional/prefetch.py:73: <link rel="prerender"
> href="static-prefetch-target.html">
> Should this should remain as prefetch and should we add another
> functional test for prerender?
>
>
> http://codereview.chromium.org/6966016/
>

[gavinp, 2011-05-23 21:58:26]

Thank you for the reviews.  I hope this upload addresses your concerns.

As well, Matt, thanks for the heads up on the potential merge conflicts.  I went
ahead and made a branch that tracks that merge, and I hope to keep that alive in
case I commit second.   If I commit first, I'll share this branch with Dominic.

http://codereview.chromium.org/6966016/diff/1/chrome/test/data/prerender/prer...
File chrome/test/data/prerender/prerender_loader.html (right):

http://codereview.chromium.org/6966016/diff/1/chrome/test/data/prerender/prer...
chrome/test/data/prerender/prerender_loader.html:22: document.write('<link
rel="prerender" href="REPLACE_WITH_PREFETCH_URL"/>');
On 2011/05/23 20:52:25, cbentzel wrote:
> nit: REPLACE_WITH_PRERENDER_URL

Done.

http://codereview.chromium.org/6966016/diff/1/chrome/test/functional/prefetch.py
File chrome/test/functional/prefetch.py (right):

http://codereview.chromium.org/6966016/diff/1/chrome/test/functional/prefetch...
chrome/test/functional/prefetch.py:73: <link rel="prerender"
href="static-prefetch-target.html">
On 2011/05/23 21:00:03, dominic wrote:
> Should this should remain as prefetch and should we add another functional
test
> for prerender?

Done.  Good catch.

Or how about no functional test for prerender, as we already have great browser
test coverage (which prefetch should get too).

http://codereview.chromium.org/6966016/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/6966016/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/resource_dispatcher_host.cc:2029: // Prefetches &
prerenders are at a lower priority than even
On 2011/05/23 20:52:25, cbentzel wrote:
> Doesn't matter for PRERENDER case, but I guess you need it due to the
> NOTREACHED() in default case.

I like to wear a belt AND suspenders.

[gavinp, 2011-05-23 22:02:21]

+darin for reviews from common/OWNERS and webkit/OWNERS .

http://webkit-commit-queue.appspot.com/queue-status/commit-queue <-- the webkit
patch on which this depends is now in the commit queue, 99463, so I'll submit
tries once we garden that far.

[mmenke, 2011-05-23 22:09:35]

LGTM

http://codereview.chromium.org/6966016/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/6966016/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/resource_dispatcher_host.cc:2029: // Prefetches &
prerenders are at a lower priority than even
On 2011/05/23 21:58:26, gavinp wrote:
> On 2011/05/23 20:52:25, cbentzel wrote:
> > Doesn't matter for PRERENDER case, but I guess you need it due to the
> > NOTREACHED() in default case.
> 
> I like to wear a belt AND suspenders.

Also, the above code is being moved out of content, so it's possible that
prerenders could theoretically end up down here when running "content" without
chrome.

[cbentzel, 2011-05-24 03:11:07]

http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/login/prefe...
File chrome/test/data/login/prefetch.html (left):

http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/login/prefe...
chrome/test/data/login/prefetch.html:2: <link rel="prefetch"
href="/auth-basic/resource.gif">
I think this wants to stay as prefetch, this test is specifically about
auth-and-prefetch rather than prerender.

http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/safe_browsi...
File chrome/test/data/safe_browsing/prefetch_malware.html (right):

http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/safe_browsi...
chrome/test/data/safe_browsing/prefetch_malware.html:21: link.rel = "prerender";
Doesn't this test also want to stay as "prefetch" instead of "prerender"?

http://codereview.chromium.org/6966016/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/6966016/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/resource_dispatcher_host.cc:2029: // Prefetches &
prerenders are at a lower priority than even
Nit: I'd spell out "and" rather than &, which makes me think bitwise-and.

[darin (slow to review), 2011-05-24 05:09:38]

LGTM for content/ and webkit/

[gavinp, 2011-05-24 13:02:52]

Thanks everyone!

http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/login/prefe...
File chrome/test/data/login/prefetch.html (left):

http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/login/prefe...
chrome/test/data/login/prefetch.html:2: <link rel="prefetch"
href="/auth-basic/resource.gif">
On 2011/05/24 03:11:07, cbentzel wrote:
> I think this wants to stay as prefetch, this test is specifically about
> auth-and-prefetch rather than prerender.

Done.

http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/safe_browsi...
File chrome/test/data/safe_browsing/prefetch_malware.html (right):

http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/safe_browsi...
chrome/test/data/safe_browsing/prefetch_malware.html:21: link.rel = "prerender";
On 2011/05/24 03:11:07, cbentzel wrote:
> Doesn't this test also want to stay as "prefetch" instead of "prerender"?

Yes.  Done.

http://codereview.chromium.org/6966016/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/6966016/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/resource_dispatcher_host.cc:2029: // Prefetches &
prerenders are at a lower priority than even
On 2011/05/24 03:11:07, cbentzel wrote:
> Nit: I'd spell out "and" rather than &, which makes me think bitwise-and.

Done.

[cbentzel, 2011-05-24 13:05:20]

LGTM

On Tue, May 24, 2011 at 9:02 AM, <gavinp@chromium.org> wrote:

> Thanks everyone!
>
>
>
>
>
http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/login/prefe...
> File chrome/test/data/login/prefetch.html (left):
>
>
>
http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/login/prefe...
> chrome/test/data/login/prefetch.html:2: <link rel="prefetch"
> href="/auth-basic/resource.gif">
> On 2011/05/24 03:11:07, cbentzel wrote:
>
>> I think this wants to stay as prefetch, this test is specifically
>>
> about
>
>> auth-and-prefetch rather than prerender.
>>
>
> Done.
>
>
>
>
http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/safe_browsi...
> File chrome/test/data/safe_browsing/prefetch_malware.html (right):
>
>
>
http://codereview.chromium.org/6966016/diff/6001/chrome/test/data/safe_browsi...
> chrome/test/data/safe_browsing/prefetch_malware.html:21: link.rel =
> "prerender";
> On 2011/05/24 03:11:07, cbentzel wrote:
>
>> Doesn't this test also want to stay as "prefetch" instead of
>>
> "prerender"?
>
> Yes.  Done.
>
>
>
>
http://codereview.chromium.org/6966016/diff/6001/content/browser/renderer_hos...
> File content/browser/renderer_host/resource_dispatcher_host.cc (right):
>
>
>
http://codereview.chromium.org/6966016/diff/6001/content/browser/renderer_hos...
> content/browser/renderer_host/resource_dispatcher_host.cc:2029: //
> Prefetches & prerenders are at a lower priority than even
> On 2011/05/24 03:11:07, cbentzel wrote:
>
>> Nit: I'd spell out "and" rather than &, which makes me think
>>
> bitwise-and.
>
> Done.
>
>
> http://codereview.chromium.org/6966016/
>

[commit-bot: I haz the power, 2011-05-24 16:15:09]

Try job failure for 6966016-1024 on mac:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2011-05-24 17:31:25]

Try job failure for 6966016-1024 on linux:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...

[commit-bot: I haz the power, 2011-05-24 19:19:50]

Change committed as 86465