Issue 6965008: Let test configuration disable variant flags. Used for preparser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6965008: Let test configuration disable variant flags. Used for preparser tests. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Visibility:
Public.

Description

Let test configuration disable variant flags. Used for preparser tests. Fixes problem with nosse[234] tests (or anything else that would pass an unexpected extra parameter on the preparser test command line). Committed: http://code.google.com/p/v8/source/detail?r=7814

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
	M	test/preparser/testcfg.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tools/test.py	View		5 chunks	+14 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

9 years, 7 months ago (2011-05-09 08:22:45 UTC) #2

LGTM

http://codereview.chromium.org/6965008/diff/1/tools/test.py
File tools/test.py (right):

http://codereview.chromium.org/6965008/diff/1/tools/test.py#newcode395
tools/test.py:395: raise BreakNowException("User pressed CTRL+C or IO went
wrong")
thanks

Expand Messages | Collapse Messages