Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: src/hydrogen-instructions.h

Issue 6964012: Simple elimination of redundant array-hole checks. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3237 matching lines...) Expand 10 before | Expand all | Expand 10 after
3248 HValue* key() { return OperandAt(1); } 3248 HValue* key() { return OperandAt(1); }
3249 3249
3250 virtual Representation RequiredInputRepresentation(int index) const { 3250 virtual Representation RequiredInputRepresentation(int index) const {
3251 // The key is supposed to be Integer32. 3251 // The key is supposed to be Integer32.
3252 return (index == 1) ? Representation::Integer32() 3252 return (index == 1) ? Representation::Integer32()
3253 : Representation::Tagged(); 3253 : Representation::Tagged();
3254 } 3254 }
3255 3255
3256 virtual void PrintDataTo(StringStream* stream); 3256 virtual void PrintDataTo(StringStream* stream);
3257 3257
3258 bool check_hole_value() const;
Kevin Millikin (Chromium) 2011/05/09 14:59:54 This should probably have a CamelCase name. I'd a
3259
3258 DECLARE_CONCRETE_INSTRUCTION(LoadKeyedFastElement) 3260 DECLARE_CONCRETE_INSTRUCTION(LoadKeyedFastElement)
3259 3261
3260 protected: 3262 protected:
3261 virtual bool DataEquals(HValue* other) { return true; } 3263 virtual bool DataEquals(HValue* other) { return true; }
3262 }; 3264 };
3263 3265
3264 3266
3265 class HLoadKeyedSpecializedArrayElement: public HBinaryOperation { 3267 class HLoadKeyedSpecializedArrayElement: public HBinaryOperation {
3266 public: 3268 public:
3267 HLoadKeyedSpecializedArrayElement(HValue* external_elements, 3269 HLoadKeyedSpecializedArrayElement(HValue* external_elements,
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
3828 3830
3829 DECLARE_CONCRETE_INSTRUCTION(In) 3831 DECLARE_CONCRETE_INSTRUCTION(In)
3830 }; 3832 };
3831 3833
3832 #undef DECLARE_INSTRUCTION 3834 #undef DECLARE_INSTRUCTION
3833 #undef DECLARE_CONCRETE_INSTRUCTION 3835 #undef DECLARE_CONCRETE_INSTRUCTION
3834 3836
3835 } } // namespace v8::internal 3837 } } // namespace v8::internal
3836 3838
3837 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 3839 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698