Issue 6964008: Make preparser-process.cc ignore flags on the command line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6964008: Make preparser-process.cc ignore flags on the command line. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make preparser-process.cc ignore flags on the command line. Avoids breaking when passed, e.g., the --nosse2 flag by certain builders. Committed: http://code.google.com/p/v8/source/detail?r=7821

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -45 lines)			Patch
	M	preparser/preparser-process.cc	View		3 chunks	+84 lines, -45 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM Maybe the testing of the preparser should not pass "strange" flags?

9 years, 7 months ago (2011-05-09 12:32:04 UTC) #2

Lasse Reichstein

9 years, 7 months ago (2011-05-09 12:38:58 UTC) #3

Oh, I agree. 
Currently it's simply appended by the builder using -Sspecial-command="@
--nosse2", which is quite indiscriminate.

Expand Messages | Collapse Messages