Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 6964005: Add IsCallable method for Object in the API (Closed)

Created:
9 years, 7 months ago by Peter Varga
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add IsCallable method for Object in the API Patch by Peter Varga. BUG=none TEST=cctest/test-api/CallableObject Committed: http://code.google.com/p/v8/source/detail?r=7828

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M include/v8.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +12 lines, -0 lines 2 comments Download
M test/cctest/test-api.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Varga
9 years, 7 months ago (2011-05-09 08:14:43 UTC) #1
Mads Ager (chromium)
9 years, 7 months ago (2011-05-09 11:38:52 UTC) #2
LGTM, I'll address these nits and land.

Thanks for the patch.

http://codereview.chromium.org/6964005/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6964005/diff/1/src/api.cc#newcode3264
src/api.cc:3264: if (obj->IsJSFunction())
Either make this a one-liner or use braces.

http://codereview.chromium.org/6964005/diff/1/src/api.cc#newcode3265
src/api.cc:3265: return true;
Two-space indent please.

Powered by Google App Engine
This is Rietveld 408576698