Issue 6964005: Add IsCallable method for Object in the API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6964005: Add IsCallable method for Object in the API (Closed)

Created:
9 years, 7 months ago by Peter Varga

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add IsCallable method for Object in the API Patch by Peter Varga. BUG=none TEST=cctest/test-api/CallableObject Committed: http://code.google.com/p/v8/source/detail?r=7828

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -0 lines)			Patch
M	include/v8.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+12 lines, -0 lines	2 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 7 months ago (2011-05-09 11:38:52 UTC) #2

LGTM, I'll address these nits and land.

Thanks for the patch.

http://codereview.chromium.org/6964005/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6964005/diff/1/src/api.cc#newcode3264
src/api.cc:3264: if (obj->IsJSFunction())
Either make this a one-liner or use braces.

http://codereview.chromium.org/6964005/diff/1/src/api.cc#newcode3265
src/api.cc:3265: return true;
Two-space indent please.

Expand Messages | Collapse Messages