Issue 6963009: Recommit "First step in letting Crankshaft inline functions with a different context.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6963009: Recommit "First step in letting Crankshaft inline functions with a different context."" (Closed)

Created:
9 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Recommit "First step in letting Crankshaft inline functions with a different context."" This reverts r7810, thus recommitting 7807. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7851

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -83 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen.h	View	7 chunks	+20 lines, -4 lines	0 comments	Download
M	src/hydrogen.cc	View	35 chunks	+62 lines, -78 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

The regression on imaging-darkroom is all due to misalignment of double spill slots. We will ...

9 years, 7 months ago (2011-05-11 09:13:00 UTC) #2

fschneider

9 years, 7 months ago (2011-05-11 10:21:55 UTC) #3

LGTM.

http://codereview.chromium.org/6963009/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6963009/diff/1/src/x64/lithium-x64.cc#newcode1191
src/x64/lithium-x64.cc:1191: LInstruction* LChunkBuilder::DoContext(HContext*
instr) {
Can you omit this instruction if it does not have any uses? 

if (instr->HasNoUses()) return NULL;

Expand Messages | Collapse Messages