A few "extract method" refactorings, trying to get individual method definitions

src/hydrogen.h

Index: src/hydrogen.h
===================================================================
--- src/hydrogen.h	(revision 7814)
+++ src/hydrogen.h	(working copy)
@@ -735,6 +735,18 @@
   INLINE_RUNTIME_FUNCTION_LIST(INLINE_FUNCTION_GENERATOR_DECLARATION)
 #undef INLINE_FUNCTION_GENERATOR_DECLARATION
 
+  void VisitUnaryOperationDelete(UnaryOperation* expr);

[Kevin Millikin (Chromium), 2011/05/09 15:14:05]

I'm not a fan of such verbose names.  I think UnaryOperation could be left
implicit: VisitDelete, VisitVoid, VisitTypeof, ..., VisitComma,
VisitLogicalOperation, VisitArithmeticOperation, ....

[Sven Panne, 2011/05/10 07:48:47]

Done.

+  void VisitUnaryOperationVoid(UnaryOperation* expr);
+  void VisitUnaryOperationTypeof(UnaryOperation* expr);
+  void VisitUnaryOperationAdd(UnaryOperation* expr);
+  void VisitUnaryOperationSub(UnaryOperation* expr);
+  void VisitUnaryOperationBitNot(UnaryOperation* expr);
+  void VisitUnaryOperationNot(UnaryOperation* expr);
+
+  void VisitBinaryOperationComma(BinaryOperation* expr);
+  void VisitBinaryOperationAndOr(BinaryOperation* expr, bool is_logical_and);
+  void VisitBinaryOperationCommon(BinaryOperation* expr);
+
   void PreProcessOsrEntry(IterationStatement* statement);
   // True iff. we are compiling for OSR and the statement is the entry.
   bool HasOsrEntryAt(IterationStatement* statement);
@@ -848,6 +860,8 @@
   HInstruction* BuildBinaryOperation(BinaryOperation* expr,
                                      HValue* left,
                                      HValue* right);
+  HInstruction* BuildBinaryOperation(Token::Value op, HValue* left,

[fschneider, 2011/05/09 15:05:35]

At the declaration we usually break the line for each parameter if it does not
fit on one line.

[Sven Panne, 2011/05/10 07:48:47]

Done.

+                                     HValue* right, TypeInfo info);
   HInstruction* BuildIncrement(HValue* value,
                                bool increment,
                                CountOperation* expr);