A few "extract method" refactorings, trying to get individual method definitions

src/hydrogen.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 717 matching lines @@
   }
 
   // Generators for inline runtime functions.
 #define INLINE_FUNCTION_GENERATOR_DECLARATION(Name, argc, ressize)      \
   void Generate##Name(CallRuntime* call);
 
   INLINE_FUNCTION_LIST(INLINE_FUNCTION_GENERATOR_DECLARATION)
   INLINE_RUNTIME_FUNCTION_LIST(INLINE_FUNCTION_GENERATOR_DECLARATION)
 #undef INLINE_FUNCTION_GENERATOR_DECLARATION
 
+  void VisitUnaryOperationDelete(UnaryOperation* expr);

[Kevin Millikin (Chromium), 2011/05/09 15:14:05]

I'm not a fan of such verbose names.  I think UnaryOperation could be left
implicit: VisitDelete, VisitVoid, VisitTypeof, ..., VisitComma,
VisitLogicalOperation, VisitArithmeticOperation, ....

[Sven Panne, 2011/05/10 07:48:47]

Done.

+  void VisitUnaryOperationVoid(UnaryOperation* expr);
+  void VisitUnaryOperationTypeof(UnaryOperation* expr);
+  void VisitUnaryOperationAdd(UnaryOperation* expr);
+  void VisitUnaryOperationSub(UnaryOperation* expr);
+  void VisitUnaryOperationBitNot(UnaryOperation* expr);
+  void VisitUnaryOperationNot(UnaryOperation* expr);
+
+  void VisitBinaryOperationComma(BinaryOperation* expr);
+  void VisitBinaryOperationAndOr(BinaryOperation* expr, bool is_logical_and);
+  void VisitBinaryOperationCommon(BinaryOperation* expr);
+
   void PreProcessOsrEntry(IterationStatement* statement);
   // True iff. we are compiling for OSR and the statement is the entry.
   bool HasOsrEntryAt(IterationStatement* statement);
 
   HBasicBlock* CreateJoin(HBasicBlock* first,
                           HBasicBlock* second,
                           int join_id);
 
   // Create a back edge in the flow graph.  body_exit is the predecessor
   // block and loop_entry is the successor block.  loop_successor is the
@@ skipping 93 matching lines @@
   void HandlePolymorphicCallNamed(Call* expr,
                                   HValue* receiver,
                                   ZoneMapList* types,
                                   Handle<String> name);
 
   HStringCharCodeAt* BuildStringCharCodeAt(HValue* string,
                                            HValue* index);
   HInstruction* BuildBinaryOperation(BinaryOperation* expr,
                                      HValue* left,
                                      HValue* right);
+  HInstruction* BuildBinaryOperation(Token::Value op, HValue* left,

[fschneider, 2011/05/09 15:05:35]

At the declaration we usually break the line for each parameter if it does not
fit on one line.

[Sven Panne, 2011/05/10 07:48:47]

Done.

+                                     HValue* right, TypeInfo info);
   HInstruction* BuildIncrement(HValue* value,
                                bool increment,
                                CountOperation* expr);
   HLoadNamedField* BuildLoadNamedField(HValue* object,
                                        Property* expr,
                                        Handle<Map> type,
                                        LookupResult* result,
                                        bool smi_and_map_check);
   HInstruction* BuildLoadNamedGeneric(HValue* object, Property* expr);
   HInstruction* BuildLoadKeyedFastElement(HValue* object,
@@ skipping 297 matching lines @@
   const char* filename_;
   HeapStringAllocator string_allocator_;
   StringStream trace_;
   int indent_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_H_