Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 6962016: Revert "Land http://codereview.chromium.org/6869009 for the third time." (Closed)

Created:
9 years, 7 months ago by oshima
Modified:
9 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Revert "Land http://codereview.chromium.org/6869009 for the third time." This reverts commit d4ff483fbf60aad0b49fddd1937774edb3ba1d7e. --- Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. --- TBR=glider@chromium.org TEST=HistogramTest.RecordedStartupTest and WebSocketTest.ServerSentData in heapchecker bot wont hang. BUG=79322 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -26 lines) Patch
M base/allocator/allocator.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/debug/leak_annotations.h View 2 chunks +1 line, -13 lines 0 comments Download
M base/metrics/histogram.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M net/disk_cache/stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/stats_histogram.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/stats_histogram.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
oshima
9 years, 7 months ago (2011-05-26 17:57:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698