Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6962012: Convert ChromiumOS input method menu to views::MenuItemView implementation. (Closed)

Created:
9 years, 7 months ago by rhashimoto
Modified:
9 years, 6 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, oshima
Visibility:
Public.

Description

Convert ChromiumOS input method menu to views::MenuItemView implementation. This is part of the removal of GTK dependencies. BUG=chromium-os:13887, chromium-os:16173 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88589

Patch Set 1 #

Patch Set 2 : Add comment for set_menu_alignment. #

Patch Set 3 : Fix menu lifetime issue with local MenuItemView. #

Patch Set 4 : Fix comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -33 lines) Patch
M chrome/browser/chromeos/login/keyboard_switch_menu.cc View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.h View 1 2 5 chunks +24 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.cc View 1 2 3 5 chunks +35 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rhashimoto
9 years, 6 months ago (2011-06-08 00:43:35 UTC) #1
Yusuke Sato
On 2011/06/08 00:43:35, rhashimoto wrote: LGTM I've confirmed that your change fixes 16173 as well. ...
9 years, 6 months ago (2011-06-08 11:02:01 UTC) #2
rhashimoto
On 2011/06/08 11:02:01, Yusuke Sato wrote: > I've confirmed that your change fixes 16173 as ...
9 years, 6 months ago (2011-06-08 15:29:25 UTC) #3
rhashimoto
Hi Denis, can you please have an OWNERS' look at this CL, too. Thanks, Roy
9 years, 6 months ago (2011-06-09 15:31:57 UTC) #4
glotov
LGTM On Thu, Jun 9, 2011 at 7:31 PM, <rhashimoto@chromium.org> wrote: > Hi Denis, can ...
9 years, 6 months ago (2011-06-09 15:41:48 UTC) #5
commit-bot: I haz the power
9 years, 6 months ago (2011-06-09 21:16:18 UTC) #6
Change committed as 88589

Powered by Google App Engine
This is Rietveld 408576698