Issue 6961043: Temporarily add media library initialization.

Issue 6961043: Temporarily add media library initialization. (Closed)

Created:
9 years, 7 months ago by Wez

Modified:
9 years, 7 months ago

Reviewers:
dmaclach1, dmac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Temporarily add media library initialization. BUG= TEST=Host plugin doesn't crash when started. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86353

Patch Set 1 #

Patch Set 2 : Load from executable, not module path, on Linux and Windows. #

Total comments: 1

Patch Set 3 : Describe the Mac OS X path fu. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	M	remoting/host/host_plugin.cc	View	1 2	2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Wez

Temporary media library loading hack until we get static linking working.

9 years, 7 months ago (2011-05-21 07:08:47 UTC) #1

dmac

LGTM http://codereview.chromium.org/6961043/diff/2001/remoting/host/host_plugin.cc File remoting/host/host_plugin.cc (right): http://codereview.chromium.org/6961043/diff/2001/remoting/host/host_plugin.cc#newcode401 remoting/host/host_plugin.cc:401: media_path = base::mac::MainAppBundlePath(); can you comment why this ...

9 years, 7 months ago (2011-05-23 16:54:50 UTC) #2

Wez

On 2011/05/23 16:54:50, dmac wrote: > LGTM > > http://codereview.chromium.org/6961043/diff/2001/remoting/host/host_plugin.cc > File remoting/host/host_plugin.cc (right): > ...

9 years, 7 months ago (2011-05-23 20:05:20 UTC) #3

dmaclach1

9 years, 7 months ago (2011-05-23 20:11:44 UTC) #4

LGTM

On Mon, May 23, 2011 at 13:05,  <wez@chromium.org> wrote:
> On 2011/05/23 16:54:50, dmac wrote:
>>
>> LGTM
>
>>
>> http://codereview.chromium.org/6961043/diff/2001/remoting/host/host_plugin.cc
>> File remoting/host/host_plugin.cc (right):
>
>
>
http://codereview.chromium.org/6961043/diff/2001/remoting/host/host_plugin.cc...
>>
>> remoting/host/host_plugin.cc:401: media_path =
>> base::mac::MainAppBundlePath();
>> can you comment why this works? because it wasn't completely clear even to
>> us
>> initially ;-)
>
> If you care about the wording if the comment, PTAL. ;)
>
> http://codereview.chromium.org/6961043/
>

Expand Messages | Collapse Messages