Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 6961039: Revert r75078 now that crbug.com/72007 is fixed. (Closed)

Created:
9 years, 7 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
jamesr
CC:
chromium-reviews, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Revert r75078 now that crbug.com/72007 is fixed. R=jamesr BUG=71735 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M content/renderer/render_thread.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/glue/webkitclient_impl.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
9 years, 7 months ago (2011-05-21 00:30:16 UTC) #1
jamesr
9 years, 7 months ago (2011-05-21 02:03:16 UTC) #2
Lgtm
On May 20, 2011 7:30 PM, <darin@chromium.org> wrote:
> Reviewers: jamesr,
>
> Description:
> Revert r75078 now that crbug.com/72007 is fixed.
>
> R=jamesr
> BUG=71735
> TEST=none
>
> Please review this at http://codereview.chromium.org/6961039/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> M content/renderer/render_thread.h
> M content/renderer/render_widget.cc
> M webkit/glue/webkitclient_impl.h
>
>
> Index: content/renderer/render_thread.h
> ===================================================================
> --- content/renderer/render_thread.h (revision 85645)
> +++ content/renderer/render_thread.h (working copy)
> @@ -213,12 +213,6 @@
> // on the renderer's main thread.
> scoped_refptr<base::MessageLoopProxy> GetFileThreadMessageLoopProxy();
>
> - // Hack for http://crbug.com/71735.
> - // TODO(jamesr): remove once http://crbug.com/72007 is fixed.
> - RendererWebKitClientImpl* GetWebKitClientImpl() const {
> - return webkit_client_.get();
> - }
> -
> // Schedule a call to IdleHandler with the given initial delay.
> void ScheduleIdleHandler(double initial_delay_s);
>
> Index: content/renderer/render_widget.cc
> ===================================================================
> --- content/renderer/render_widget.cc (revision 85645)
> +++ content/renderer/render_widget.cc (working copy)
> @@ -609,10 +609,6 @@
> this, &RenderWidget::AnimationCallback), 16);
> animation_task_posted_ = true;
> animation_update_pending_ = false;
> - // Explicitly pump the WebCore Timer queue to avoid starvation on OS X.
> - // See crbug.com/71735.
> - // TODO(jamesr) Remove this call once crbug.com/72007 is fixed.
> - RenderThread::current()->GetWebKitClientImpl()->DoTimeout();
> webwidget_->animate();
> return;
> }
> Index: webkit/glue/webkitclient_impl.h
> ===================================================================
> --- webkit/glue/webkitclient_impl.h (revision 85645)
> +++ webkit/glue/webkitclient_impl.h (working copy)
> @@ -78,15 +78,12 @@
> void SuspendSharedTimer();
> void ResumeSharedTimer();
>
> - // Hack for http://crbug.com/71735.
> - // TODO(jamesr): move this back to the private section once
> - // http://crbug.com/72007 is fixed.
> + private:
> void DoTimeout() {
> if (shared_timer_func_ && !shared_timer_suspended_)
> shared_timer_func_();
> }
>
> - private:
> MessageLoop* main_loop_;
> base::OneShotTimer<WebKitClientImpl> shared_timer_;
> void (*shared_timer_func_)();
>
>

Powered by Google App Engine
This is Rietveld 408576698