Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/extensions/extension_cookies_api.h

Issue 6961027: Change event routers from singletons to being owned by the ExtensionService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: asargent and dmazzoni's comments Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_cookies_api.h
diff --git a/chrome/browser/extensions/extension_cookies_api.h b/chrome/browser/extensions/extension_cookies_api.h
index 286c8badb014dddf0435f4f610c877f9672e9aa6..a2d119603aa6e6b3f920578314f6940c56fea053 100644
--- a/chrome/browser/extensions/extension_cookies_api.h
+++ b/chrome/browser/extensions/extension_cookies_api.h
@@ -12,7 +12,6 @@
#include <string>
#include "base/memory/ref_counted.h"
-#include "base/memory/singleton.h"
#include "base/time.h"
#include "chrome/browser/extensions/extension_function.h"
#include "chrome/browser/net/chrome_cookie_notification_details.h"
@@ -31,17 +30,12 @@ class URLRequestContextGetter;
// extension system.
class ExtensionCookiesEventRouter : public NotificationObserver {
public:
- // Single instance of the event router.
- static ExtensionCookiesEventRouter* GetInstance();
+ explicit ExtensionCookiesEventRouter() {}
+ virtual ~ExtensionCookiesEventRouter() {}
asargent_no_longer_on_chrome 2011/05/24 18:18:00 same nit here about inlining
void Init();
private:
- friend struct DefaultSingletonTraits<ExtensionCookiesEventRouter>;
-
- ExtensionCookiesEventRouter() {}
- virtual ~ExtensionCookiesEventRouter() {}
-
// NotificationObserver implementation.
virtual void Observe(NotificationType type,
const NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698