Change event routers from singletons to being owned by the ExtensionService.

chrome/browser/chromeos/extensions/file_browser_event_router.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_browser_event_router.h"
 
 #include "base/json/json_writer.h"
 #include "base/memory/singleton.h"
 #include "base/stl_util-inl.h"
 #include "base/values.h"
@@ skipping 29 matching lines @@
     const chromeos::MountLibrary::Disk* disk) {
   DictionaryValue* result = new DictionaryValue();
   result->SetString("mountPath", disk->mount_path());
   result->SetString("label", disk->device_label());
   result->SetString("deviceType", DeviceTypeToString(disk->device_type()));
   result->SetInteger("totalSizeKB", disk->total_size() / 1024);
   result->SetBoolean("readOnly", disk->is_read_only());
   return result;
 }
 
-ExtensionFileBrowserEventRouter::ExtensionFileBrowserEventRouter()
-    : profile_(NULL) {
-}
-
-ExtensionFileBrowserEventRouter::~ExtensionFileBrowserEventRouter() {
-}
-
-void ExtensionFileBrowserEventRouter::ObserveFileSystemEvents(
-    Profile* profile) {
-  if (!profile)
-    return;
-  profile_ = profile;
+ExtensionFileBrowserEventRouter::ExtensionFileBrowserEventRouter(
+    Profile* profile)
+    : profile_(profile) {
+  DCHECK(profile);
   if (!chromeos::CrosLibrary::Get()->EnsureLoaded())
     return;
   if (chromeos::UserManager::Get()->user_is_logged_in()) {
     chromeos::MountLibrary* lib =
         chromeos::CrosLibrary::Get()->GetMountLibrary();
     lib->RemoveObserver(this);
     lib->AddObserver(this);
     lib->RequestMountInfoRefresh();
   }

[asargent_no_longer_on_chrome, 2011/05/24 18:18:00]

nit: I think this code block should be moved into an Init method as well. 

[Yoyo Zhou, 2011/05/24 19:17:55]

Done.

 }
 
-void ExtensionFileBrowserEventRouter::StopObservingFileSystemEvents() {
+ExtensionFileBrowserEventRouter::~ExtensionFileBrowserEventRouter() {
   if (!profile_)
     return;
   if (!chromeos::CrosLibrary::Get()->EnsureLoaded())
     return;
   chromeos::MountLibrary* lib =
       chromeos::CrosLibrary::Get()->GetMountLibrary();
   lib->RemoveObserver(this);
   profile_ = NULL;
 }
 
-// static
-ExtensionFileBrowserEventRouter*
-    ExtensionFileBrowserEventRouter::GetInstance() {
-  return Singleton<ExtensionFileBrowserEventRouter>::get();
-}
-
 void ExtensionFileBrowserEventRouter::DiskChanged(
     chromeos::MountLibraryEventType event,
     const chromeos::MountLibrary::Disk* disk) {
   if (event == chromeos::MOUNT_DISK_ADDED) {
     OnDiskAdded(disk);
   } else if (event == chromeos::MOUNT_DISK_REMOVED) {
     OnDiskRemoved(disk);
   } else if (event == chromeos::MOUNT_DISK_CHANGED) {
     OnDiskChanged(disk);
   }
@@ skipping 150 matching lines @@
        ++iter) {
     const std::string& notification_device_path = iter->first;
     // Doing a sub string match so that we find if this new one is a subdevice
     // of another already inserted device.
     if (StartsWithASCII(system_path, notification_device_path, true)) {
       return iter;
     }
   }
   return notifications_.end();
 }