Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: src/arm/lithium-arm.h

Issue 6961019: Prevent deopt on double value assignment to typed arrays (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: more review feedback Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1621 matching lines...) Expand 10 before | Expand all | Expand 10 after
1632 // Sometimes truncating conversion from a tagged value to an int32. 1632 // Sometimes truncating conversion from a tagged value to an int32.
1633 class LDoubleToI: public LTemplateInstruction<1, 1, 2> { 1633 class LDoubleToI: public LTemplateInstruction<1, 1, 2> {
1634 public: 1634 public:
1635 LDoubleToI(LOperand* value, LOperand* temp1, LOperand* temp2) { 1635 LDoubleToI(LOperand* value, LOperand* temp1, LOperand* temp2) {
1636 inputs_[0] = value; 1636 inputs_[0] = value;
1637 temps_[0] = temp1; 1637 temps_[0] = temp1;
1638 temps_[1] = temp2; 1638 temps_[1] = temp2;
1639 } 1639 }
1640 1640
1641 DECLARE_CONCRETE_INSTRUCTION(DoubleToI, "double-to-i") 1641 DECLARE_CONCRETE_INSTRUCTION(DoubleToI, "double-to-i")
1642 DECLARE_HYDROGEN_ACCESSOR(Change) 1642 DECLARE_HYDROGEN_ACCESSOR(UnaryOperation)
1643 1643
1644 bool truncating() { return hydrogen()->CanTruncateToInt32(); } 1644 bool truncating() { return hydrogen()->CanTruncateToInt32(); }
1645 }; 1645 };
1646 1646
1647 1647
1648 // Truncating conversion from a tagged value to an int32. 1648 // Truncating conversion from a tagged value to an int32.
1649 class LTaggedToI: public LTemplateInstruction<1, 1, 3> { 1649 class LTaggedToI: public LTemplateInstruction<1, 1, 3> {
1650 public: 1650 public:
1651 LTaggedToI(LOperand* value, 1651 LTaggedToI(LOperand* value,
1652 LOperand* temp1, 1652 LOperand* temp1,
1653 LOperand* temp2, 1653 LOperand* temp2,
1654 LOperand* temp3) { 1654 LOperand* temp3) {
1655 inputs_[0] = value; 1655 inputs_[0] = value;
1656 temps_[0] = temp1; 1656 temps_[0] = temp1;
1657 temps_[1] = temp2; 1657 temps_[1] = temp2;
1658 temps_[2] = temp3; 1658 temps_[2] = temp3;
1659 } 1659 }
1660 1660
1661 DECLARE_CONCRETE_INSTRUCTION(TaggedToI, "tagged-to-i") 1661 DECLARE_CONCRETE_INSTRUCTION(TaggedToI, "tagged-to-i")
1662 DECLARE_HYDROGEN_ACCESSOR(Change) 1662 DECLARE_HYDROGEN_ACCESSOR(UnaryOperation)
1663 1663
1664 bool truncating() { return hydrogen()->CanTruncateToInt32(); } 1664 bool truncating() { return hydrogen()->CanTruncateToInt32(); }
1665 }; 1665 };
1666 1666
1667 1667
1668 class LSmiTag: public LTemplateInstruction<1, 1, 0> { 1668 class LSmiTag: public LTemplateInstruction<1, 1, 0> {
1669 public: 1669 public:
1670 explicit LSmiTag(LOperand* value) { 1670 explicit LSmiTag(LOperand* value) {
1671 inputs_[0] = value; 1671 inputs_[0] = value;
1672 } 1672 }
(...skipping 666 matching lines...) Expand 10 before | Expand all | Expand 10 after
2339 2339
2340 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2340 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2341 }; 2341 };
2342 2342
2343 #undef DECLARE_HYDROGEN_ACCESSOR 2343 #undef DECLARE_HYDROGEN_ACCESSOR
2344 #undef DECLARE_CONCRETE_INSTRUCTION 2344 #undef DECLARE_CONCRETE_INSTRUCTION
2345 2345
2346 } } // namespace v8::internal 2346 } } // namespace v8::internal
2347 2347
2348 #endif // V8_ARM_LITHIUM_ARM_H_ 2348 #endif // V8_ARM_LITHIUM_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698