Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 6961014: Modify settings page text when syncing. (Closed)

Created:
9 years, 7 months ago by Sheridan Rawlins
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews), csilv
Visibility:
Public.

Description

Modify settings page text when syncing. - Created new strings for syncing with and without profile. - Altered sync service observation to check service's StatusSummary for SYNCING. - use innerHTML to allow links in the status string. BUG=80892 R=jhawkins@chromium.org TEST=set up sync, view chrome://settings/personal, change, add, or delete a bookmark - see syncing briefly, then back to synced. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86236

Patch Set 1 #

Patch Set 2 : fix string description and don't use local var for error. #

Total comments: 3

Patch Set 3 : only use one text regardless of whether multiprofile or single. #

Patch Set 4 : Adjusted from Syncing to Last synced to. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/personal_options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 2 1 chunk +13 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sheridan Rawlins
Update status string during syncing.
9 years, 7 months ago (2011-05-20 07:01:18 UTC) #1
James Hawkins
http://codereview.chromium.org/6961014/diff/1001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/6961014/diff/1001/chrome/app/generated_resources.grd#newcode7958 chrome/app/generated_resources.grd:7958: Syncing Chrome profile <ph name="USER_EMAIL_ADDRESS"> You should ask mirandac, ...
9 years, 7 months ago (2011-05-20 22:33:05 UTC) #2
Sheridan Rawlins
Miranda, Can you reply to James' comment about using the same string for multi-profile and ...
9 years, 7 months ago (2011-05-20 22:48:24 UTC) #3
Miranda Callahan
http://codereview.chromium.org/6961014/diff/1001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/6961014/diff/1001/chrome/app/generated_resources.grd#newcode7958 chrome/app/generated_resources.grd:7958: Syncing Chrome profile <ph name="USER_EMAIL_ADDRESS"> On 2011/05/20 22:33:06, James ...
9 years, 7 months ago (2011-05-21 10:51:30 UTC) #4
Sheridan Rawlins
http://codereview.chromium.org/6961014/diff/1001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/6961014/diff/1001/chrome/app/generated_resources.grd#newcode7958 chrome/app/generated_resources.grd:7958: Syncing Chrome profile <ph name="USER_EMAIL_ADDRESS"> On 2011/05/21 10:51:30, Miranda ...
9 years, 7 months ago (2011-05-22 02:29:11 UTC) #5
James Hawkins
LGTM, thanks.
9 years, 7 months ago (2011-05-22 02:32:18 UTC) #6
commit-bot: I haz the power
9 years, 7 months ago (2011-05-22 09:27:41 UTC) #7
Change committed as 86236

Powered by Google App Engine
This is Rietveld 408576698