Allow chrome to become the os default handler for arbitrary protocols on mac/win.

chrome/installer/setup/uninstall.cc

Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index 6aeee430051aa54318d8d406e11e72c7d7cab7ca..31e7034b233606cabecb2744cc250f0749e9259e 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -559,8 +559,9 @@ bool DeleteChromeRegistrationKeys(BrowserDistribution* dist, HKEY root,
   std::wstring parent_key(ShellUtil::kRegClasses);
   const std::wstring::size_type base_length = parent_key.size();
   std::wstring child_key;
-  for (const wchar_t* const* proto = &ShellUtil::kProtocolAssociations[0];
-       *proto != NULL; ++proto) {
+  for (const wchar_t* const* proto =
+      &ShellUtil::kPotentialProtocolAssociations[0];

[Mark Mentovai, 2011/05/23 00:23:52]

I find this difficult to read because you’ve got three lines, which usually
correspond to the three expressions inside a “for (…)” construct. Your first
expression is spread across two lines, and then the remaining two expressions
share a line.

Also, the indentation on the second and third lines is incorrect.

Here’s one option to clean this up:

  for (const wchar_t* const* proto =
           &ShellUtil::kPotentialProtocolAssociations[0];
       *proto != NULL;
       ++proto) {

Here’s another, with a slight semantic change in |proto|’s scope:

  const wchar_t* const* proto;
  for (proto = &ShellUtil::kPotentialProtocolAssociations[0]; *proto; ++proto) {

There are other valid ways to address this.

[benwells, 2011/05/23 06:08:37]

Ah great, thanks for the suggestion. That looks much better.

On 2011/05/23 00:23:52, Mark Mentovai wrote:

[benwells, 2011/05/24 06:10:38]

Done.

+      *proto != NULL; ++proto) {
     parent_key.resize(base_length);
     file_util::AppendToPath(&parent_key, *proto);
     child_key.assign(parent_key).append(ShellUtil::kRegShellOpen);