Allow chrome to become the os default handler for arbitrary protocols on mac/win.

chrome/installer/setup/setup_main.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <msi.h>
 #include <shellapi.h>
 #include <shlobj.h>
 
 #include <string>
@@ skipping 820 matching lines @@
     if (installer::EULA_REJECTED != *exit_code)
       GoogleUpdateSettings::SetEULAConsent(*installer_state, true);
   } else if (cmd_line.HasSwitch(
       installer::switches::kRegisterChromeBrowser)) {
     const Product* chrome_install =
         installer_state->FindProduct(BrowserDistribution::CHROME_BROWSER);
     if (chrome_install) {
       // If --register-chrome-browser option is specified, register all
       // Chrome protocol/file associations as well as register it as a valid
       // browser for Start Menu->Internet shortcut. This option should only
       // be used when setup.exe is launched with admin rights. We do not

[robertshield, 2011/05/24 21:33:44]

The behaviour of RegisterChromeBrowser below if setup.exe is NOT launched with
admin rights is to silently avoid attempting HKLM registration. If the comment
is correct here and really means that setup.exe MUST be running with admin
rights when this flag is used then could we DCHECK() / LOG(DFATAL) or some such
if the user is not currently elevated?

[benwells, 2011/05/25 08:07:19]

I am reluctant to make this change now as part of this CL, as I feel it will
warrant some specific testing on various OS versions (i.e. XP and 7) before
landing it. I've added http://crbug.com/83845 to make this change in a way that
won't hold up landing the registerProtocolHandler feature.

       // make any user specific changes in this option.

[grt (UTC plus 2), 2011/05/24 20:27:53]

Please update this comment so that it accurately describes the new
--register-url-protocol switch.

[benwells, 2011/05/25 08:07:19]

Done.

       std::wstring chrome_exe(cmd_line.GetSwitchValueNative(
           installer::switches::kRegisterChromeBrowser));
       std::wstring suffix;
       if (cmd_line.HasSwitch(
           installer::switches::kRegisterChromeBrowserSuffix)) {
         suffix = cmd_line.GetSwitchValueNative(
             installer::switches::kRegisterChromeBrowserSuffix);
       }
-      *exit_code = ShellUtil::RegisterChromeBrowser(
-          chrome_install->distribution(), chrome_exe, suffix, false);
+      if (cmd_line.HasSwitch(
+          installer::switches::kRegisterURLProtocol)) {
+        std::wstring protocol = cmd_line.GetSwitchValueNative(
+            installer::switches::kRegisterURLProtocol);
+        *exit_code = ShellUtil::RegisterChromeForProtocol(
+            chrome_install->distribution(), chrome_exe, suffix, protocol,
+            false);

[robertshield, 2011/05/24 21:33:44]

The return value here is a bool and is being shoved into an int. While that may
work, it looks unintentional. Can we check the return value instead and use one
of the installer::InstallStatus constants instead?

[benwells, 2011/05/25 08:07:19]

Done.

+      } else {
+        *exit_code = ShellUtil::RegisterChromeBrowser(
+            chrome_install->distribution(), chrome_exe, suffix, false);
+      }
     } else {
       LOG(DFATAL) << "Can't register browser - Chrome distribution not found";
       *exit_code = installer::UNKNOWN_STATUS;
     }
   } else if (cmd_line.HasSwitch(installer::switches::kRenameChromeExe)) {
     // If --rename-chrome-exe is specified, we want to rename the executables
     // and exit.
     *exit_code = RenameChromeExecutables(original_state, installer_state);
   } else if (cmd_line.HasSwitch(
       installer::switches::kRemoveChromeRegistration)) {
@@ skipping 345 matching lines @@
   if (!(installer_state.is_msi() && is_uninstall))
     // Note that we allow the status installer::UNINSTALL_REQUIRES_REBOOT
     // to pass through, since this is only returned on uninstall which is
     // never invoked directly by Google Update.
     return_code = InstallUtil::GetInstallReturnCode(install_status);
 
   VLOG(1) << "Installation complete, returning: " << return_code;
 
   return return_code;
 }