Issue 6961007: WebSocket over SPDY.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6961007: WebSocket over SPDY. (Closed)

Created:
9 years, 7 months ago by Takashi Toyoshima

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Work in progress: WebSocket over SPDY. WebSocket would use SpdySession opened for the same host:port if any. This change takes over from http://codereview.chromium.org/3020068/ . memo(toyoshim): Now I'll take over ukai-san's last change. This change is in progress and not ready for review yet. BUG=42320 TEST=net_unittests

Patch Set 1 #

Patch Set 2 : update to be compiled with trunk #

Patch Set 3 : remove one TODO and do some minor refactoring #

Patch Set 4 : remove SocketStream::GetHostPortPair() #

Patch Set 5 : refactoring includes removing stream_id() #

Patch Set 6 : improve to keep returning result on SendData() #

Patch Set 7 : introduce chrome://flags configuration #

Patch Set 8 : rebase #

Patch Set 9 : rebased #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -14 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2 3 4 5 6 7 8	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2 3 4 5 6 7 8	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/websockets/websocket_job.h	View	1 2 3 4 5 6 7 8	4 chunks	+15 lines, -1 line	0 comments	Download
M	net/websockets/websocket_job.cc	View	1 2 3 4 5 6 7 8	4 chunks	+99 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

9 years, 7 months ago (2011-05-20 02:33:41 UTC) #2

Thanks, Ben.

But the change I request a review is following one.
http://codereview.chromium.org/7047003/ .
I'm sorry for confusing you.

I'd like to submit that before do this.
Changes around the flags are the same.
Could you give me a LGTM for that, too?

After that, this change will be rebased, then flags changes will be removed from
this change.
Actually, this issue is not published for review, yet.

Expand Messages | Collapse Messages