Change chrome to use the new native themed radio button.

Change chrome to use the new native themed radio button.

While testing the chromeos password changed dialog, I noticed that the dialog
was clipped at the bottom, so that the text field to enter the old password
was not fully visible.  This was with and without my change.  To fix, I
increase the height of the dialog, hence the locale_settings.grd change.

BUG=None
TEST=Make sure all uses of radio buttons in chrome, on all platforms including
chromeos, work as expected.  The look may be slightly different, but the
behaviour should be the same.  To test the password changed dialog on chromeos,
login and then logout with a given account.  Change the password of that
account (with another computer for example) and then log back in using the
new password.  The text field at the bottom should not be clipped.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86283

[tfarina, 2011-05-13 19:14:01]

http://codereview.chromium.org/6955002/diff/8004/views/examples/radio_button_...
File views/examples/radio_button_example.h (right):

http://codereview.chromium.org/6955002/diff/8004/views/examples/radio_button_...
views/examples/radio_button_example.h:35: views::NativeRadioButton*
radio_buttons_[3];
Invert the name of these two member variables?

[Ben Goodger (Google), 2011-05-13 19:18:00]

Have you verified we behave consistently with a11y etc?

[(NOT FOR CODE REVIEWS), 2011-05-13 19:36:32]

Hi Ben,

I have not done anything manually.  What do I need to do?

Thanks,
Roger

-



On Fri, May 13, 2011 at 15:18,  <ben@chromium.org> wrote:
> Have you verified we behave consistently with a11y etc?
>
> http://codereview.chromium.org/6955002/
>

[Ben Goodger (Google), 2011-05-13 19:47:14]

+dominic.

Dominic, Is there a set of steps that Roger can use to test his changes to
RadioButton wrt a11y?

-Ben

On Fri, May 13, 2011 at 12:36 PM, Roger Tawa <rogerta@google.com> wrote:

> Hi Ben,
>
> I have not done anything manually.  What do I need to do?
>
> Thanks,
> Roger
>
> -
>
>
>
> On Fri, May 13, 2011 at 15:18,  <ben@chromium.org> wrote:
> > Have you verified we behave consistently with a11y etc?
> >
> > http://codereview.chromium.org/6955002/
> >
>

[dmazzoni, 2011-05-13 20:00:14]

Sure - if you can test it with at least one Windows screen reader and
verify it's working, I'd be reasonably sure that it will work with
other such tools.

The fastest to get up and running will be the open-source screen
reader NVDA: http://www.nvda-project.org/ - download and install the
latest version (2011.1), go through the initial dialog boxes until it
starts talking, then open up a Chrome dialog with a new radio button.
Press Tab to focus the radio button and make sure it reads the name of
the radio button and the fact that it's a radio button. Use the up and
down arrows to switch between choices and make sure it announces them.
Then exit NVDA from the icon in the tool tray.

If you encounter any problems, I'd be happy to take a closer look, but
if that works, then I'd assume all is well.

Thanks!

- Dominic

On Fri, May 13, 2011 at 12:47 PM, Ben Goodger (Google) <ben@chromium.org> wrote:
> +dominic.
> Dominic, Is there a set of steps that Roger can use to test his changes to
> RadioButton wrt a11y?
> -Ben
>
> On Fri, May 13, 2011 at 12:36 PM, Roger Tawa <rogerta@google.com> wrote:
>>
>> Hi Ben,
>>
>> I have not done anything manually.  What do I need to do?
>>
>> Thanks,
>> Roger
>>
>> -
>>
>>
>>
>> On Fri, May 13, 2011 at 15:18,  <ben@chromium.org> wrote:
>> > Have you verified we behave consistently with a11y etc?
>> >
>> > http://codereview.chromium.org/6955002/
>> >
>
>

[(NOT FOR CODE REVIEWS), 2011-05-13 20:53:12]

Thanks for the pointers Dominic.

I tried with NVDA with the scenarios you mention.  All looks good.

Roger

-



On Fri, May 13, 2011 at 16:00, Dominic Mazzoni <dmazzoni@chromium.org> wrote:
> Sure - if you can test it with at least one Windows screen reader and
> verify it's working, I'd be reasonably sure that it will work with
> other such tools.
>
> The fastest to get up and running will be the open-source screen
> reader NVDA: http://www.nvda-project.org/ - download and install the
> latest version (2011.1), go through the initial dialog boxes until it
> starts talking, then open up a Chrome dialog with a new radio button.
> Press Tab to focus the radio button and make sure it reads the name of
> the radio button and the fact that it's a radio button. Use the up and
> down arrows to switch between choices and make sure it announces them.
> Then exit NVDA from the icon in the tool tray.
>
> If you encounter any problems, I'd be happy to take a closer look, but
> if that works, then I'd assume all is well.
>
> Thanks!
>
> - Dominic
>
> On Fri, May 13, 2011 at 12:47 PM, Ben Goodger (Google) <ben@chromium.org>
wrote:
>> +dominic.
>> Dominic, Is there a set of steps that Roger can use to test his changes to
>> RadioButton wrt a11y?
>> -Ben
>>
>> On Fri, May 13, 2011 at 12:36 PM, Roger Tawa <rogerta@google.com> wrote:
>>>
>>> Hi Ben,
>>>
>>> I have not done anything manually.  What do I need to do?
>>>
>>> Thanks,
>>> Roger
>>>
>>> -
>>>
>>>
>>>
>>> On Fri, May 13, 2011 at 15:18,  <ben@chromium.org> wrote:
>>> > Have you verified we behave consistently with a11y etc?
>>> >
>>> > http://codereview.chromium.org/6955002/
>>> >
>>
>>
>

[Ben Goodger (Google), 2011-05-13 20:55:18]

LGTM then.

On Fri, May 13, 2011 at 1:52 PM, Roger Tawa <rogerta@google.com> wrote:

> Thanks for the pointers Dominic.
>
> I tried with NVDA with the scenarios you mention.  All looks good.
>
> Roger
>
> -
>
>
>
> On Fri, May 13, 2011 at 16:00, Dominic Mazzoni <dmazzoni@chromium.org>
> wrote:
> > Sure - if you can test it with at least one Windows screen reader and
> > verify it's working, I'd be reasonably sure that it will work with
> > other such tools.
> >
> > The fastest to get up and running will be the open-source screen
> > reader NVDA: http://www.nvda-project.org/ - download and install the
> > latest version (2011.1), go through the initial dialog boxes until it
> > starts talking, then open up a Chrome dialog with a new radio button.
> > Press Tab to focus the radio button and make sure it reads the name of
> > the radio button and the fact that it's a radio button. Use the up and
> > down arrows to switch between choices and make sure it announces them.
> > Then exit NVDA from the icon in the tool tray.
> >
> > If you encounter any problems, I'd be happy to take a closer look, but
> > if that works, then I'd assume all is well.
> >
> > Thanks!
> >
> > - Dominic
> >
> > On Fri, May 13, 2011 at 12:47 PM, Ben Goodger (Google) <ben@chromium.org>
> wrote:
> >> +dominic.
> >> Dominic, Is there a set of steps that Roger can use to test his changes
> to
> >> RadioButton wrt a11y?
> >> -Ben
> >>
> >> On Fri, May 13, 2011 at 12:36 PM, Roger Tawa <rogerta@google.com>
> wrote:
> >>>
> >>> Hi Ben,
> >>>
> >>> I have not done anything manually.  What do I need to do?
> >>>
> >>> Thanks,
> >>> Roger
> >>>
> >>> -
> >>>
> >>>
> >>>
> >>> On Fri, May 13, 2011 at 15:18,  <ben@chromium.org> wrote:
> >>> > Have you verified we behave consistently with a11y etc?
> >>> >
> >>> > http://codereview.chromium.org/6955002/
> >>> >
> >>
> >>
> >
>

[Roger Tawa OOO till Jul 10th, 2011-05-20 15:32:51]

http://codereview.chromium.org/6955002/diff/8004/views/examples/radio_button_...
File views/examples/radio_button_example.h (right):

http://codereview.chromium.org/6955002/diff/8004/views/examples/radio_button_...
views/examples/radio_button_example.h:35: views::NativeRadioButton*
radio_buttons_[3];
On 2011/05/13 19:14:01, tfarina wrote:
> Invert the name of these two member variables?

Done.

[tfarina, 2011-05-20 23:43:44]

http://codereview.chromium.org/6955002/diff/16001/views/examples/radio_button...
File views/examples/radio_button_example.cc (right):

http://codereview.chromium.org/6955002/diff/16001/views/examples/radio_button...
views/examples/radio_button_example.cc:48: for (size_t i = 0; i <
arraysize(native_radio_buttons_); i++) {
nit: ++i here and below.

http://codereview.chromium.org/6955002/diff/16001/views/examples/radio_button...
File views/examples/radio_button_example.h (right):

http://codereview.chromium.org/6955002/diff/16001/views/examples/radio_button...
views/examples/radio_button_example.h:14: #include
"views/controls/button/text_button.h"
I think you can forward declare TextButton instead.

[Roger Tawa OOO till Jul 10th, 2011-05-22 23:39:27]

http://codereview.chromium.org/6955002/diff/16001/views/examples/radio_button...
File views/examples/radio_button_example.cc (right):

http://codereview.chromium.org/6955002/diff/16001/views/examples/radio_button...
views/examples/radio_button_example.cc:48: for (size_t i = 0; i <
arraysize(native_radio_buttons_); i++) {
On 2011/05/20 23:43:45, tfarina wrote:
> nit: ++i here and below.

Done.

http://codereview.chromium.org/6955002/diff/16001/views/examples/radio_button...
File views/examples/radio_button_example.h (right):

http://codereview.chromium.org/6955002/diff/16001/views/examples/radio_button...
views/examples/radio_button_example.h:14: #include
"views/controls/button/text_button.h"
On 2011/05/20 23:43:45, tfarina wrote:
> I think you can forward declare TextButton instead.

Done.

[commit-bot: I haz the power, 2011-05-23 03:23:18]

Try job failure for 6955002-23001 on mac:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...