Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 6954010: Change ZIP and last name heuristic pattern. (Closed)

Created:
9 years, 7 months ago by honten.org
Modified:
9 years, 7 months ago
CC:
chromium-reviews, GeorgeY, Ilya Sherman
Visibility:
Public.

Description

Change ZIP and last name heuristic pattern. In ZIP heuristic patter, there is "cp". But it is too short and it matches first/last name fiels. So I change it to "^cp$". "secondname" was a specified as last name. So I added. BUG=76332, 76331 TEST=1, put yahoo and super shuttle grabber input files. 2.run browser_tests --gtest_filter=*.DataDrivenHeuristics and see the inferred results. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/autofill/autofill_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
honten.org
Changed some heuristics for yahoo and super shuttle. Please review.
9 years, 7 months ago (2011-05-07 03:22:18 UTC) #1
Ilya Sherman
LGTM, thanks :) David should also sign off on this before it gets committed, though.
9 years, 7 months ago (2011-05-07 09:09:41 UTC) #2
honten.org
Thank, Ilya, I'm waiting for his review... On 2011/05/07 09:09:41, Ilya Sherman wrote: > LGTM, ...
9 years, 7 months ago (2011-05-09 02:10:37 UTC) #3
dhollowa
LGTM. Thanks. On 2011/05/09 02:10:37, honten wrote: > Thank, Ilya, > > I'm waiting for ...
9 years, 7 months ago (2011-05-09 15:13:11 UTC) #4
honten.org
Could you commit my change as usual? On 2011/05/09 15:13:11, dhollowa wrote: > LGTM. Thanks. ...
9 years, 7 months ago (2011-05-09 17:03:26 UTC) #5
commit-bot: I haz the power
Presubmit check for 6954010-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 7 months ago (2011-05-09 17:08:34 UTC) #6
dhollowa
Done.
9 years, 7 months ago (2011-05-09 17:08:47 UTC) #7
dhollowa
Apparently not. I'll have to do this manually I guess. On 2011/05/09 17:08:47, dhollowa wrote: ...
9 years, 7 months ago (2011-05-09 17:09:45 UTC) #8
takano.naoki_gmail.com
Yeah... Heuristic strings exceed 80 chars limitation;-) On Mon, May 9, 2011 at 10:09 AM, ...
9 years, 7 months ago (2011-05-09 17:11:39 UTC) #9
dhollowa
9 years, 7 months ago (2011-05-09 18:55:32 UTC) #10
Really done.

On 2011/05/09 17:11:39, takano.naoki_gmail.com wrote:
> Yeah...
> 
> Heuristic strings exceed 80 chars limitation;-)
> 
> On Mon, May 9, 2011 at 10:09 AM,  <mailto:dhollowa@chromium.org> wrote:
> > Apparently not. &nbsp;I'll have to do this manually I guess.
> >
> > On 2011/05/09 17:08:47, dhollowa wrote:
> >>
> >> Done.
> >
> >
> >
> > http://codereview.chromium.org/6954010/
> >

Powered by Google App Engine
This is Rietveld 408576698