Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6953014: Added icu support for FreeBSD (Closed)

Created:
9 years, 7 months ago by ruben
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Updated to trunk from last week Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85319

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Updated to trunk from last week #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -7 lines) Patch
M README.chromium View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M icu.gyp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
A public/common/unicode/pfreebsd.h View 1 2 1 chunk +401 lines, -0 lines 0 comments Download
M public/common/unicode/ptypes.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ruben
I just updated the icu patch for FreeBSD that was previously LGTM'ed, please review.
9 years, 7 months ago (2011-05-07 00:43:49 UTC) #1
Peter Kasting
LGTM. Kinda sad if we don't have a better way in our gyp files of ...
9 years, 7 months ago (2011-05-07 00:51:22 UTC) #2
ruben
On 2011/05/07 00:51:22, Peter Kasting wrote: > LGTM. Kinda sad if we don't have a ...
9 years, 7 months ago (2011-05-12 22:58:30 UTC) #3
jungshik at Google
LGTM. I'm landing it on your behalf. Sorry that it didn't get landed earlier.
9 years, 7 months ago (2011-05-13 20:47:27 UTC) #4
jungshik at Google
9 years, 7 months ago (2011-05-13 21:06:47 UTC) #5 
Landed as noted in the CL description.

Powered by Google App Engine
This is Rietveld 408576698