Issue 6952011: CrOS - Check current state of update-engine on startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6952011: CrOS - Check current state of update-engine on startup (Closed)

Created:
9 years, 7 months ago by James Cook

Modified:
9 years, 7 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

CrOS - Check current state of update-engine on startup Fix bug where Chrome OS does not report that a reboot is needed if Chrome has crashed since the update was applied. BUG=chromium-os:14853 TEST=See bug for details. Basically, download and install an update, but don't reboot. Crash chrome intentionally. Go to wrench > About Chrome OS. Verify that it tells you a rebooted is needed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84805

Patch Set 1 #

Patch Set 2 : Ready for review #

Patch Set 3 : Now with cros.DEPS #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/chromeos/cros/update_library.cc	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
	M	tools/cros.DEPS/DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Cook

Have a look - it's basically a single call to load the state of the ...

9 years, 7 months ago (2011-05-09 19:45:34 UTC) #1

lgtm

Expand Messages | Collapse Messages