Product-specific flags are no longer required, used, or validated in --rename-chrome-exe command ...

Product-specific flags are no longer required, used, or validated in --rename-chrome-exe command lines.

BUG=79935
TEST=Install version N-1 w/ --verbose-logging --chrome --chrome-frame --multi-install --ready-mode --system-level, navigate to gcf:about:version in IE, then install version N with same args.  Inspect chrome_frame_installer.log and note the lack of validation errors.  Close IE and note that the update completes and all "opv" and "cmd" values are removed from the various ClientState keys.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84641

[grt (UTC plus 2), 2011-05-07 03:18:47]

http://codereview.chromium.org/6951016/diff/1/chrome/installer/setup/setup_ma...
File chrome/installer/setup/setup_main.cc (right):

http://codereview.chromium.org/6951016/diff/1/chrome/installer/setup/setup_ma...
chrome/installer/setup/setup_main.cc:149: void AddExistingMultiInstalls(const
InstallationState& original_state,
Note to reviewers: this function was simply moved up in the file.  It was not
changed in any way.

[robertshield, 2011-05-09 14:03:57]

lg, couple of meta-nits

http://codereview.chromium.org/6951016/diff/1/chrome/installer/setup/setup_ma...
File chrome/installer/setup/setup_main.cc (right):

http://codereview.chromium.org/6951016/diff/1/chrome/installer/setup/setup_ma...
chrome/installer/setup/setup_main.cc:152: BrowserDistribution::Type
product_checks[] = {
We have occurrences of this particular array in a couple of places, it occurs to
me that this makes it slightly harder to add a new product in the future. Having
the list of known products in a single location feels more maintainable. 
Don't have to do this in this CL, but add a TODO()?

http://codereview.chromium.org/6951016/diff/1/chrome/installer/setup/setup_ma...
chrome/installer/setup/setup_main.cc:222: std::mem_fun(&Product::distribution))
- &dists[0];
The above eight lines are a bit too clever imo. They look like an optimally
concise expression of what you mean but I don't think I could debug this or that
it would make newcomers eager to modify this code.

Could you replace this with a longer but simpler variant or factor it into a
separate documented method explaining how it works?

[grt (UTC plus 2), 2011-05-09 14:29:52]

PTAL

http://codereview.chromium.org/6951016/diff/1/chrome/installer/setup/setup_ma...
File chrome/installer/setup/setup_main.cc (right):

http://codereview.chromium.org/6951016/diff/1/chrome/installer/setup/setup_ma...
chrome/installer/setup/setup_main.cc:152: BrowserDistribution::Type
product_checks[] = {
On 2011/05/09 14:03:57, robertshield wrote:
> We have occurrences of this particular array in a couple of places, it occurs
to
> me that this makes it slightly harder to add a new product in the future.
Having
> the list of known products in a single location feels more maintainable. 
> Don't have to do this in this CL, but add a TODO()?

Done.

http://codereview.chromium.org/6951016/diff/1/chrome/installer/setup/setup_ma...
chrome/installer/setup/setup_main.cc:222: std::mem_fun(&Product::distribution))
- &dists[0];
On 2011/05/09 14:03:57, robertshield wrote:
> The above eight lines are a bit too clever imo. They look like an optimally
> concise expression of what you mean but I don't think I could debug this or
that
> it would make newcomers eager to modify this code.
> 
> Could you replace this with a longer but simpler variant or factor it into a
> separate documented method explaining how it works?

Done.

[robertshield, 2011-05-09 15:20:28]

LGTM

[commit-bot: I haz the power, 2011-05-09 17:57:12]

Change committed as 84641