Issue 6951013: add MessageLoopProxy in MessageLoopFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6951013: add MessageLoopProxy in MessageLoopFactory (Closed)

Created:
9 years, 7 months ago by wjia(left Chromium)

Modified:
9 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

add MessageLoopProxy in MessageLoopFactory bug=None TEST=try bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84540

Patch Set 1 #

Total comments: 1

Patch Set 2 : correct file order #

Patch Set 3 : use full name #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
M	media/base/message_loop_factory.h	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download
M	media/base/message_loop_factory_impl.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	media/base/message_loop_factory_impl.cc	View	1 2	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

Andrew, Could you take a look? This is a helper for VideoCaptureImpl.

9 years, 7 months ago (2011-05-06 22:59:46 UTC) #1

scherkus (not reviewing)

one nit but acolwell can you take a look? http://codereview.chromium.org/6951013/diff/1/media/base/message_loop_factory.h File media/base/message_loop_factory.h (right): http://codereview.chromium.org/6951013/diff/1/media/base/message_loop_factory.h#newcode33 media/base/message_loop_factory.h:33: ...

9 years, 7 months ago (2011-05-06 23:01:45 UTC) #2

LGTM

Expand Messages | Collapse Messages