Issue 6948013: Fix dangerous downloads. Ellipsis for long filenames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6948013: Fix dangerous downloads. Ellipsis for long filenames. (Closed)

Created:
9 years, 7 months ago by achuithb

Modified:
9 years, 6 months ago

Reviewers:
zel

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix dangerous downloads. Ellipsis for long filenames. BUG=chromium-os:15048, chromium-os:15049 TEST=Go to achuithz600.mtv.corp.google.com/www/files. Download the crx file and the file with the long name to test dangerous downloads and long filename fix respectively. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84548

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Total comments: 2

Patch Set 9 : '' #

Patch Set 10 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -103 lines)			Patch
	M	chrome/browser/resources/active_downloads.html	View	1 2 3 4 5 6 7 8 9	16 chunks	+153 lines, -100 lines	0 comments	Download
	M	chrome/browser/ui/webui/active_downloads_ui.cc	View	1 2 3 4 5 6 7 8	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

Just need one person to review please, but I need to check this in by ...

9 years, 7 months ago (2011-05-07 03:39:11 UTC) #1

zel

LGTM approved for merge into 742 http://codereview.chromium.org/6948013/diff/7004/chrome/browser/resources/active_downloads.html File chrome/browser/resources/active_downloads.html (right): http://codereview.chromium.org/6948013/diff/7004/chrome/browser/resources/active_downloads.html#newcode564 chrome/browser/resources/active_downloads.html:564: if (this.allowdownload) { ...

9 years, 7 months ago (2011-05-07 04:49:21 UTC) #2

achuithb

9 years, 7 months ago (2011-05-07 05:09:57 UTC) #3

http://codereview.chromium.org/6948013/diff/7004/chrome/browser/resources/act...
File chrome/browser/resources/active_downloads.html (right):

http://codereview.chromium.org/6948013/diff/7004/chrome/browser/resources/act...
chrome/browser/resources/active_downloads.html:564: if (this.allowdownload) {
On 2011/05/07 04:49:21, zel wrote:
> nit: not need for {}

Done.

Expand Messages | Collapse Messages