Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 6948010: [Sync] Log time spent configuring data types (Closed)

Created:
9 years, 7 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana
Visibility:
Public.

Description

[Sync] Log time spent configuring data types Add UMA histograms, too. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84732

Patch Set 1 #

Patch Set 2 : Fix unittest failures #

Total comments: 2

Patch Set 3 : Address comments #

Patch Set 4 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M chrome/browser/sync/glue/data_type_manager.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.h View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 1 2 4 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+zea for review
9 years, 7 months ago (2011-05-06 23:16:35 UTC) #1
akalin
On 2011/05/06 23:16:35, akalin wrote: > +zea for review Fixed erroneous use of histograms.
9 years, 7 months ago (2011-05-07 00:35:33 UTC) #2
Nicolas Zea
http://codereview.chromium.org/6948010/diff/4001/chrome/browser/sync/glue/data_type_manager_impl.cc File chrome/browser/sync/glue/data_type_manager_impl.cc (right): http://codereview.chromium.org/6948010/diff/4001/chrome/browser/sync/glue/data_type_manager_impl.cc#newcode390 chrome/browser/sync/glue/data_type_manager_impl.cc:390: VLOG(1) << "NotifyDone called with result: " << result_str; ...
9 years, 7 months ago (2011-05-07 00:39:35 UTC) #3
akalin
Please take another look. http://codereview.chromium.org/6948010/diff/4001/chrome/browser/sync/glue/data_type_manager_impl.cc File chrome/browser/sync/glue/data_type_manager_impl.cc (right): http://codereview.chromium.org/6948010/diff/4001/chrome/browser/sync/glue/data_type_manager_impl.cc#newcode390 chrome/browser/sync/glue/data_type_manager_impl.cc:390: VLOG(1) << "NotifyDone called with ...
9 years, 7 months ago (2011-05-09 22:19:56 UTC) #4
Nicolas Zea
9 years, 7 months ago (2011-05-09 22:24:00 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld 408576698