Issue 6937001: Compare IC: add STRINGS state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6937001: Compare IC: add STRINGS state. (Closed)

Created:
9 years, 7 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Compare IC: add STRINGS state. BUG=1340 Committed: http://code.google.com/p/v8/source/detail?r=7783

Patch Set 4 : Ports #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -0 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 2 3	1 chunk	+65 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/code-stubs.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+77 lines, -0 lines	0 comments	Download
M	src/ic.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ic.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+75 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

Looks great! http://codereview.chromium.org/6937001/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/6937001/diff/1/src/ia32/code-stubs-ia32.cc#newcode5852 src/ia32/code-stubs-ia32.cc:5852: // becase we already know they are ...

9 years, 7 months ago (2011-05-04 14:49:35 UTC) #2

Vitaly Repeshko

Ports uploaded. Please take another look. Thanks, Vitaly http://codereview.chromium.org/6937001/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/6937001/diff/1/src/ia32/code-stubs-ia32.cc#newcode5852 src/ia32/code-stubs-ia32.cc:5852: // ...

9 years, 7 months ago (2011-05-04 16:04:49 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 6937001: Compare IC: add STRINGS state. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Ports #

Patch Set 3 : Ports #

Patch Set 4 : Ports #

Messages