Autofill DOMUI Prefs should work with i18n phone numbers

Autofill DOMUI Prefs should work with i18n phone numbers

Adds validation to the phone and fax lists in WebUI based prefs for Autofill.  Also adds the start of phone_number_i18n.cc/h module.

BUG=80101
TEST=PhoneNumberI18NTest.PhoneNumbersMatch

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84518

[dhollowa, 2011-05-06 01:06:36]

Follow-up from http://codereview.chromium.org/6930037/

The only difference with this CL is the addition of the phonenumber_proto
dependency in the chrome_browser.gypi file.

[GeorgeY, 2011-05-06 01:32:25]

On 2011/05/06 01:06:36, dhollowa wrote:
> Follow-up from http://codereview.chromium.org/6930037/
> 
> The only difference with this CL is the addition of the phonenumber_proto
> dependency in the chrome_browser.gypi file.

LGTM

[James Hawkins, 2011-05-06 20:34:11]

http://codereview.chromium.org/6935033/diff/1/chrome/browser/autofill/phone_n...
File chrome/browser/autofill/phone_number_i18n.cc (right):

http://codereview.chromium.org/6935033/diff/1/chrome/browser/autofill/phone_n...
chrome/browser/autofill/phone_number_i18n.cc:11: using namespace
i18n::phonenumbers;
Don't use entire namespaces.

http://codereview.chromium.org/6935033/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/autofill_options_handler.cc (right):

http://codereview.chromium.org/6935033/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/autofill_options_handler.cc:123: ListValue**
list_value,
What are the contents of |list_value|? I propose that the answer to that
question should be used to name this parameter better.

http://codereview.chromium.org/6935033/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/autofill_options_handler.cc:125: double number =
0.0;
Why particularly using a double?

[dhollowa, 2011-05-06 21:00:19]

http://codereview.chromium.org/6935033/diff/1/chrome/browser/autofill/phone_n...
File chrome/browser/autofill/phone_number_i18n.cc (right):

http://codereview.chromium.org/6935033/diff/1/chrome/browser/autofill/phone_n...
chrome/browser/autofill/phone_number_i18n.cc:11: using namespace
i18n::phonenumbers;
On 2011/05/06 20:34:11, James Hawkins wrote:
> Don't use entire namespaces.

Done.

http://codereview.chromium.org/6935033/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/autofill_options_handler.cc (right):

http://codereview.chromium.org/6935033/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/autofill_options_handler.cc:123: ListValue**
list_value,
On 2011/05/06 20:34:11, James Hawkins wrote:
> What are the contents of |list_value|? I propose that the answer to that
> question should be used to name this parameter better.

Done.

http://codereview.chromium.org/6935033/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/autofill_options_handler.cc:125: double number =
0.0;
All numbers come across from JavaScript as doubles, even integer values.  I've
added comment to clarify.

On 2011/05/06 20:34:11, James Hawkins wrote:
> Why particularly using a double?

[James Hawkins, 2011-05-06 21:59:39]

LGTM