Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 6935033: Autofill DOMUI Prefs should work with i18n phone numbers (Closed)

Created:
9 years, 7 months ago by dhollowa
Modified:
9 years, 7 months ago
Reviewers:
GeorgeY, James Hawkins
CC:
chromium-reviews, Paweł Hajdan Jr., Ilya Sherman, arv (Not doing code reviews), dhollowa
Visibility:
Public.

Description

Autofill DOMUI Prefs should work with i18n phone numbers Adds validation to the phone and fax lists in WebUI based prefs for Autofill. Also adds the start of phone_number_i18n.cc/h module. BUG=80101 TEST=PhoneNumberI18NTest.PhoneNumbersMatch Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84518

Patch Set 1 #

Total comments: 6

Patch Set 2 : Namespace and comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -4 lines) Patch
A chrome/browser/autofill/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/autofill/phone_number_i18n.h View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/autofill/phone_number_i18n.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/autofill/phone_number_i18n_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_address_overlay.js View 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/autofill_options_list.js View 4 chunks +67 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 4 chunks +89 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dhollowa
Follow-up from http://codereview.chromium.org/6930037/ The only difference with this CL is the addition of the phonenumber_proto ...
9 years, 7 months ago (2011-05-06 01:06:36 UTC) #1
GeorgeY
On 2011/05/06 01:06:36, dhollowa wrote: > Follow-up from http://codereview.chromium.org/6930037/ > > The only difference with ...
9 years, 7 months ago (2011-05-06 01:32:25 UTC) #2
James Hawkins
http://codereview.chromium.org/6935033/diff/1/chrome/browser/autofill/phone_number_i18n.cc File chrome/browser/autofill/phone_number_i18n.cc (right): http://codereview.chromium.org/6935033/diff/1/chrome/browser/autofill/phone_number_i18n.cc#newcode11 chrome/browser/autofill/phone_number_i18n.cc:11: using namespace i18n::phonenumbers; Don't use entire namespaces. http://codereview.chromium.org/6935033/diff/1/chrome/browser/ui/webui/options/autofill_options_handler.cc File ...
9 years, 7 months ago (2011-05-06 20:34:11 UTC) #3
dhollowa
http://codereview.chromium.org/6935033/diff/1/chrome/browser/autofill/phone_number_i18n.cc File chrome/browser/autofill/phone_number_i18n.cc (right): http://codereview.chromium.org/6935033/diff/1/chrome/browser/autofill/phone_number_i18n.cc#newcode11 chrome/browser/autofill/phone_number_i18n.cc:11: using namespace i18n::phonenumbers; On 2011/05/06 20:34:11, James Hawkins wrote: ...
9 years, 7 months ago (2011-05-06 21:00:19 UTC) #4
James Hawkins
9 years, 7 months ago (2011-05-06 21:59:39 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698