Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5657)

Unified Diff: chrome/browser/download/download_manager_unittest.cc

Issue 6935032: Include full redirect chain in downloads safebrowsing ping. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: initialize url_chain in tests Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/download/download_safe_browsing_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_manager_unittest.cc
diff --git a/chrome/browser/download/download_manager_unittest.cc b/chrome/browser/download/download_manager_unittest.cc
index 7b10e86fd593a21a0672aacc6b7b83ffd331c42a..9365846cffc5f778e5b7efebea014169865773e6 100644
--- a/chrome/browser/download/download_manager_unittest.cc
+++ b/chrome/browser/download/download_manager_unittest.cc
@@ -348,6 +348,7 @@ TEST_F(DownloadManagerTest, DownloadRenameTest) {
DownloadCreateInfo* info(new DownloadCreateInfo);
info->download_id = static_cast<int>(i);
info->prompt_user_for_save_location = false;
+ info->url_chain.push_back(GURL());
info->is_dangerous_file = kDownloadRenameCases[i].is_dangerous_file;
info->is_dangerous_url = kDownloadRenameCases[i].is_dangerous_url;
FilePath new_path(kDownloadRenameCases[i].suggested_path);
@@ -402,6 +403,7 @@ TEST_F(DownloadManagerTest, DownloadInterruptTest) {
DownloadCreateInfo* info(new DownloadCreateInfo);
info->download_id = static_cast<int>(0);
info->prompt_user_for_save_location = false;
+ info->url_chain.push_back(GURL());
info->is_dangerous_file = false;
info->is_dangerous_url = false;
const FilePath new_path(FILE_PATH_LITERAL("foo.zip"));
@@ -467,6 +469,7 @@ TEST_F(DownloadManagerTest, DownloadCancelTest) {
DownloadCreateInfo* info(new DownloadCreateInfo);
info->download_id = static_cast<int>(0);
info->prompt_user_for_save_location = false;
+ info->url_chain.push_back(GURL());
info->is_dangerous_file = false;
info->is_dangerous_url = false;
const FilePath new_path(FILE_PATH_LITERAL("foo.zip"));
@@ -545,6 +548,7 @@ TEST_F(DownloadManagerTest, DownloadOverwriteTest) {
DownloadCreateInfo* info(new DownloadCreateInfo);
info->download_id = static_cast<int>(0);
info->prompt_user_for_save_location = true;
+ info->url_chain.push_back(GURL());
info->is_dangerous_file = false;
info->is_dangerous_url = false;
« no previous file with comments | « no previous file | chrome/browser/download/download_safe_browsing_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698