Include full redirect chain in downloads safebrowsing ping.

chrome/browser/safe_browsing/protocol_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/protocol_manager.h"
 
 #ifndef NDEBUG
 #include "base/base64.h"
 #endif
 #include "base/environment.h"
@@ skipping 642 matching lines @@
   GURL report_url = SafeBrowsingHitUrl(malicious_url, page_url,
                                        referrer_url, is_subresource,
                                        threat_type);
   URLFetcher* report = new URLFetcher(report_url, URLFetcher::GET, this);
   report->set_load_flags(net::LOAD_DISABLE_CACHE);
   report->set_request_context(request_context_getter_);
   report->Start();
   safebrowsing_reports_.insert(report);
 }
 
+void SafeBrowsingProtocolManager::ReportSafeBrowsingHitWithChain(
+    const std::vector<GURL>& url_chain,
+    const GURL& referrer_url,
+    bool is_subresource,
+    SafeBrowsingService::UrlCheckResult threat_type) {
+  std::string post_data;
+  for (size_t i = 0; i < url_chain.size(); ++i)
+    post_data += url_chain[i].spec() + "\n";
+
+  GURL report_url = SafeBrowsingHitUrl(url_chain.back(), url_chain.front(),

[noelutz, 2011/05/06 04:24:12]

Do you ever check that there is at least one element in the chain?

[panayiotis, 2011/05/09 19:44:16]

A check would be nice yes. 

On 2011/05/06 04:24:12, noelutz wrote:

[mattm, 2011/05/10 02:26:09]

Added a DCHECK to DownloadSBClient constructor

+                                       referrer_url, is_subresource,
+                                       threat_type);
+  URLFetcher* report = new URLFetcher(report_url, URLFetcher::POST, this);
+  report->set_load_flags(net::LOAD_DISABLE_CACHE);
+  report->set_request_context(request_context_getter_);
+  report->set_upload_data("text/plain", post_data);
+  report->Start();
+  safebrowsing_reports_.insert(report);
+}
+
 // Sends malware details for users who opt-in.
 void SafeBrowsingProtocolManager::ReportMalwareDetails(
     const std::string& report) {
   GURL report_url = MalwareDetailsUrl();
   URLFetcher* fetcher = new URLFetcher(report_url, URLFetcher::POST, this);
   fetcher->set_load_flags(net::LOAD_DISABLE_CACHE);
   fetcher->set_request_context(request_context_getter_);
   fetcher->set_upload_data("application/octet-stream", report);
   // Don't try too hard to send reports on failures.
   fetcher->set_automatically_retry_on_5xx(false);
@@ skipping 142 matching lines @@
   if (!additional_query_.empty()) {
     if (next_url.find("?") != std::string::npos) {
       next_url.append("&");
     } else {
       next_url.append("?");
     }
     next_url.append(additional_query_);
   }
   return GURL(next_url);
 }