Issue 6933048: Tiny refactorings to improve the readability of the compiler pipeline a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6933048: Tiny refactorings to improve the readability of the compiler pipeline a bit. (Closed)

Created:
9 years, 7 months ago by Sven Panne

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Tiny refactorings to improve the readability of the compiler pipeline a bit. Committed: http://code.google.com/p/v8/source/detail?r=7802

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -31 lines)			Patch
	M	src/compiler.cc	View		3 chunks	+25 lines, -31 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/6933048/diff/1/src/compiler.cc File src/compiler.cc (right): http://codereview.chromium.org/6933048/diff/1/src/compiler.cc#newcode116 src/compiler.cc:116: static bool is_debugging_active() { I prefer debugging_is_active as ...

9 years, 7 months ago (2011-05-06 10:51:31 UTC) #2

Sven Panne

9 years, 7 months ago (2011-05-06 11:01:06 UTC) #3

http://codereview.chromium.org/6933048/diff/1/src/compiler.cc
File src/compiler.cc (right):

http://codereview.chromium.org/6933048/diff/1/src/compiler.cc#newcode116
src/compiler.cc:116: static bool is_debugging_active() {
On 2011/05/06 10:51:31, Kevin Millikin wrote:
> I prefer debugging_is_active as a name, but I don't care too much either :)

I don't have very strong feelings about this, either, but I think it's
consistent with the rest of the is_blah()-predicates. :-)

Expand Messages | Collapse Messages