Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/objects-visiting.cc

Issue 6932068: A first skeleton for introducing Harmony proxies (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Addressed Kevin's comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 case CODE_TYPE: 82 case CODE_TYPE:
83 return kVisitCode; 83 return kVisitCode;
84 84
85 case JS_GLOBAL_PROPERTY_CELL_TYPE: 85 case JS_GLOBAL_PROPERTY_CELL_TYPE:
86 return kVisitPropertyCell; 86 return kVisitPropertyCell;
87 87
88 case SHARED_FUNCTION_INFO_TYPE: 88 case SHARED_FUNCTION_INFO_TYPE:
89 return kVisitSharedFunctionInfo; 89 return kVisitSharedFunctionInfo;
90 90
91 case JS_PROXY_TYPE:
92 return GetVisitorIdForSize(kVisitDataObject,
Vyacheslav Egorov (Chromium) 2011/05/22 14:45:50 This introduces a subtle GC problem: JS_PROXY is n
rossberg 2011/05/23 08:45:28 Done.
93 kVisitDataObjectGeneric,
94 JSProxy::kSize);
95
91 case PROXY_TYPE: 96 case PROXY_TYPE:
92 return GetVisitorIdForSize(kVisitDataObject, 97 return GetVisitorIdForSize(kVisitDataObject,
93 kVisitDataObjectGeneric, 98 kVisitDataObjectGeneric,
94 Proxy::kSize); 99 Proxy::kSize);
95 100
96 case FILLER_TYPE: 101 case FILLER_TYPE:
97 return kVisitDataObjectGeneric; 102 return kVisitDataObjectGeneric;
98 103
99 case JS_OBJECT_TYPE: 104 case JS_OBJECT_TYPE:
100 case JS_CONTEXT_EXTENSION_OBJECT_TYPE: 105 case JS_CONTEXT_EXTENSION_OBJECT_TYPE:
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 kVisitStructGeneric, 139 kVisitStructGeneric,
135 instance_size); 140 instance_size);
136 141
137 default: 142 default:
138 UNREACHABLE(); 143 UNREACHABLE();
139 return kVisitorIdCount; 144 return kVisitorIdCount;
140 } 145 }
141 } 146 }
142 147
143 } } // namespace v8::internal 148 } } // namespace v8::internal
OLDNEW
« src/heap.cc ('K') | « src/objects-printer.cc ('k') | src/proxy.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698