Remove presubmit warning for long lines in .grd files

presubmit_support.py

Index: presubmit_support.py
===================================================================
--- presubmit_support.py	(revision 84086)
+++ presubmit_support.py	(working copy)
@@ -314,7 +314,8 @@
     if depot_path:
       return depot_path
 
-  def AffectedFiles(self, include_dirs=False, include_deletes=True):
+  def AffectedFiles(self, include_dirs=False, include_deletes=True,
+                    file_filter=None):
     """Same as input_api.change.AffectedFiles() except only lists files
     (and optionally directories) in the same directory as the current presubmit
     script, or subdirectories thereof.
@@ -322,9 +323,10 @@
     dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
     if len(dir_with_slash) == 1:
       dir_with_slash = ''
+
     return filter(
         lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
-        self.change.AffectedFiles(include_dirs, include_deletes))
+        self.change.AffectedFiles(include_dirs, include_deletes, file_filter))
 
   def LocalPaths(self, include_dirs=False):
     """Returns local paths of input_api.AffectedFiles()."""
@@ -715,12 +717,14 @@
       raise AttributeError(self, attr)
     return self.tags.get(attr)
 
-  def AffectedFiles(self, include_dirs=False, include_deletes=True):
+  def AffectedFiles(self, include_dirs=False, include_deletes=True,
+                    file_filter=None):
     """Returns a list of AffectedFile instances for all files in the change.
 
     Args:
       include_deletes: If false, deleted files will be filtered out.
       include_dirs: True to include directories in the list
+      file_filter: An additional filter to apply.
 
     Returns:
       [AffectedFile(path, action), AffectedFile(path, action)]
@@ -730,6 +734,9 @@
     else:
       affected = filter(lambda x: not x.IsDirectory(), self._affected_files)
 
+    if file_filter:
+      affected = filter(lambda x: file_filter(x), affected)

[M-A Ruel, 2011/05/09 20:13:44]

You can simplify that:

affected = filter(file_filter, affected)

because:
- "lambda x: file_filter(x)" == "file_filter"
- filter(None, affected) works. Look up the docs for more info.

so no need for "if file_filter". Awesome, eh?

[sail, 2011/05/10 16:53:25]

Done. Cool!

+
     if include_deletes:
       return affected
     else: